Windows env #16
Windows env #16
Conversation
Vagrantfile
Outdated
|
|
||
| config.vm.provision "shell", privileged: false, inline: <<-SHELL | ||
| # install git | ||
| sudo apt-get -y install git |
There was a problem hiding this comment.
Why aren't we just installing git in the larger apt-get install below?
There was a problem hiding this comment.
No reason to be honest - just the order in which I wrote the instructions. Although I think it's nice for the requirements to be expressed explicitly, happy to change it.
There was a problem hiding this comment.
Don't worry about changing it just yet... I wanted to chat through this PR with Leon anyway as we'd already been pondering whether we should be using ansible to set up the VM image in the first place. Perhaps that is being too purist in the approach, but given that we're trying to teach people about how to use ansible, it would probably be nice if we were using it ourselves for fulfilling the pre-reqs steps too.
There was a problem hiding this comment.
@jonrob and I just had a quick chat and agreed the following:
We will move any setup steps from the vagrant steps and run them along with the others that are triggered by bin/setup.
We will then play #9 to get the setup script converted to Ansible and therefore draw a line under using Bash for the setup scripts.
No description provided.