-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release changelog for 4.3.0 #226
Conversation
Wow - thank you @woensug-choi and @j-herman for getting a head start on this! I'll take the lead on it and will ask folks for details were needed. I'll ask @mabelzhang for a review once we are close and then merge it when I tag the release. |
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
@bsb808 Do we want to merge this PR in the other repo before tagging the release? Field-Robotics-Lab/nps_uw_multibeam_sonar#38 I've just approved it. If we want, I can merge that one, otherwise we can wait for Woensug's daytime. How do we do the joint release - will that repo be tagged separately anyway? |
@mabelzhang Doing them at the same time would be ideal. Go ahead and merge Field-Robotics-Lab/nps_uw_multibeam_sonar#38 |
Field-Robotics-Lab/nps_uw_multibeam_sonar#38 has been merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed some URLs
Pending: #207
If it gets merged, should add to changelog.
Although, the relevant wiki page has already been added under "Coming Soon." So maybe the PR could get added there too.
Co-authored-by: Mabel Zhang <mabel@openrobotics.org>
Just moved both to the changelog, since we found the problem! Hoping I didn't just jinx it, but 207 should be merged shortly. |
I'm glad I'm not the only one who believes in jinxing. |
Co-authored-by: Mabel Zhang <mabel@openrobotics.org>
Co-authored-by: Mabel Zhang <mabel@openrobotics.org>
Co-authored-by: Mabel Zhang <mabel@openrobotics.org>
Co-authored-by: Mabel Zhang <mabel@openrobotics.org>
@mabelzhang - good to merge? |
A draft we all can work on.
I've added my parts including the ones that are not on Trello.