Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/join org us8.1 #2378

Merged
merged 18 commits into from
May 19, 2021
Merged

Feature/join org us8.1 #2378

merged 18 commits into from
May 19, 2021

Conversation

xJamesScott
Copy link
Collaborator

@xJamesScott xJamesScott commented May 14, 2021

What does this pull request aim to achieve? 馃挴

Merge into JoinOrg feature branch

Dependencies / Test exclusions:

  • API / Backend, owners / admins cannot accept members. Static test data is in place currently [ 7.1 / 7.2 ].
  • Member profile links, test members are not actual profiles (7.1 / 7.2)
  • I have checked that no one else is working on similar changes.
  • I have read the latest README and understand the development workflow.
  • The name of this branch is: feature/<branch_name> for a regular feature, hotfix/<branch_name> for a hotfix, and service/<branch_name> for a microservice, where <branch_name> briefly describes the issue(s) resolved and is prefixed with the issue number(s) (e.g. 1127-1130-update-git-branching-model). The branch is created in a cloned version of this repo, not a forked repo.
  • This branch is rebased/merged with the latest staging (or the latest production if it is a hotfix).
  • There are no merge conflicts.
  • There are no console warnings and errors.
  • On the right hand side of this PR, I have linked the appropriate issue(s) under "Issues" and added a project progress under "Projects".

@todo
Copy link

todo bot commented May 14, 2021

- SWAP OUT MEMBER STATIC TEST DATA FOR API CALL

// TODO - SWAP OUT MEMBER STATIC TEST DATA FOR API CALL
// const {
// data: { data: applicants, meta },
// } = await axios.get(endpoint);


This comment was generated by todo based on a TODO comment in b4e4c49 in #2378. cc @FightPandemics.

@todo
Copy link

todo bot commented May 14, 2021

- REMOVE ORG WORKSPACE TEST LINK

// TODO - REMOVE ORG WORKSPACE TEST LINK
}
<Link
style={{ color: "red", "font-weight": "bold" }}
to={`/orgworkspace/${organisationId}`}
>TEST ORG WORKSPACE LINK</Link>


This comment was generated by todo based on a TODO comment in b4e4c49 in #2378. cc @FightPandemics.

@github-actions
Copy link

Build URL: https://featurejoin-org-US81.fightpandemics.xyz. Please wait a few minutes for the deployment to complete.

@hiran11 hiran11 added this to Ready for Testing in Join Org May 17, 2021
@hiran11 hiran11 moved this from Ready for Testing to In Testing in Join Org May 17, 2021
@xJamesScott xJamesScott merged commit 8028625 into feature/join-org May 19, 2021
@xJamesScott xJamesScott deleted the feature/join-org-US8.1 branch May 19, 2021 18:43
@xJamesScott xJamesScott removed this from In Testing in Join Org May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant