Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set server usage for client certificates #274

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

travisgroth
Copy link

Closes #273

@gaby
Copy link

gaby commented Jul 28, 2020

@FiloSottile Any plans to merge this?

@gaby
Copy link

gaby commented Oct 21, 2021

@travisgroth Can you rebase this pr ?

@gaby gaby mentioned this pull request Jan 16, 2022
@moparisthebest
Copy link

letsencrypt certs have both server and client set:

X509v3 Extended Key Usage: 
                TLS Web Server Authentication, TLS Web Client Authentication

Which is required for protocols like XMPP

So currently I'm using -client to create certificates like letsencrypt makes to test XMPP things, it'd be a shame if that was removed. Probably what should happen is without -client it should add both key usages and then -client could take away only TLS Web Server Authentication ?

@gaby
Copy link

gaby commented Mar 24, 2022

@moparisthebest Maybe there should be different modes for this flags. Like default should be (server + client). If the -client then only client, if -server then only server?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client certs also specify Server usage
3 participants