This repository has been archived by the owner on Jan 11, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
UPPSF-131 Added parameterised waiting interval in the call to contentResolver (document-store-api) to avoid getting still not existing content there #19
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnov
reviewed
Jul 25, 2019
helm/content-collection-unfolder/app-configs/content-collection-unfolder_delivery.yaml
Outdated
Show resolved
Hide resolved
rnov
reviewed
Jul 25, 2019
rnov
reviewed
Jul 26, 2019
rnov
suggested changes
Jul 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as we agreed, all defer calls must handle errors a candidates to check :
./forwarder/forwarder.go:48: defer resp.Body.Close()
./forwarder/forwarder_test.go:35: defer r.Body.Close()
./forwarder/forwarder_test.go:57: defer mockServer.Close()
./forwarder/forwarder_test.go:68: defer mockServer.Close()
./forwarder/forwarder_test.go:80: defer mockServer.Close()
./relations/relationsResolver_test.go:24: defer file.Close()
./relations/relationsResolver.go:33: defer resp.Body.Close()
./healthcheck.go:129: defer resp.Body.Close()
./common_test.go:50: defer file.Close()
./unfolder.go:73: defer req.Body.Close()
./unfolder_test.go:32: defer server.Close()
./unfolder_test.go:54: defer server.Close()
./unfolder_test.go:65: defer resp.Body.Close()
./unfolder_test.go:86: defer server.Close()
./unfolder_test.go:100: defer resp.Body.Close()
./unfolder_test.go:127: defer server.Close()
./unfolder_test.go:151: defer resp.Body.Close()
./unfolder_test.go:176: defer server.Close()
./unfolder_test.go:201: defer resp.Body.Close()
./unfolder_test.go:230: defer server.Close()
./unfolder_test.go:254: defer resp.Body.Close()
./unfolder_test.go:285: defer server.Close()
./unfolder_test.go:315: defer resp.Body.Close()
./unfolder_test.go:345: defer server.Close()
./unfolder_test.go:378: defer resp.Body.Close()
./unfolder_test.go:404: defer server.Close()
./unfolder_test.go:443: defer resp.Body.Close()
./unfolder_test.go:461: defer server.Close()
./unfolder_test.go:485: defer resp.Body.Close()
./resolver/contentResolver.go:34: defer resp.Body.Close()
./resolver/contentResolver.go:113: defer resp.Body.Close()
./resolver/contentResolver_test.go:30: defer file.Close()
./resolver/uuidResolver_test.go:86: defer file.Close()
./main_test.go:39: defer writerServer.Close()
./main_test.go:42: defer contentResolverServer.Close()
./main_test.go:45: defer relationsResolverServer.Close()
./main_test.go:52: defer unfolderServer.Close()
./main_test.go:59: defer resp.Body.Close()
./main_test.go:79: defer writerServer.Close()
./main_test.go:82: defer contentResolverServer.Close()
./main_test.go:85: defer relationsResolverServer.Close()
./main_test.go:92: defer unfolderServer.Close()
./main_test.go:99: defer resp.Body.Close()
./main_test.go:119: defer writerServer.Close()
./main_test.go:122: defer contentResolverServer.Close()
./main_test.go:125: defer relationsResolverServer.Close()
./main_test.go:132: defer unfolderServer.Close()
./main_test.go:138: defer resp.Body.Close()
./main_test.go:161: defer r.Body.Close()
./main_test.go:67: json.Unmarshal(body, &healthResult)
./main_test.go:107: json.Unmarshal(body, &healthResult)
@@ -19,6 +19,7 @@ type serviceConfig struct { | |||
kafkaAddr *string | |||
kafkaHostname *string | |||
kafkaAuth *string | |||
requestTimeout *int |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the point in general to use pointers for unmutable values like string or ints ?
rnov
previously approved these changes
Jul 31, 2019
gkazakov111
force-pushed
the
fix/UPPSF-131-different-notifs-count-EU-US
branch
from
July 31, 2019 14:06
b2841ff
to
75b07dc
Compare
fixed EOL's and a number Added: - parameterised waiting interval in the call to contentResolver (document-store-api) to avoid getting still not existing content there - test updated and checked for not having races * Removed an alias in config file fixed one failing test
gkazakov111
force-pushed
the
fix/UPPSF-131-different-notifs-count-EU-US
branch
from
August 8, 2019 10:19
75b07dc
to
f7c045a
Compare
gotha
approved these changes
Aug 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.