Skip to content
This repository has been archived by the owner on Jan 11, 2021. It is now read-only.

UPPSF-131 Added parameterised waiting interval in the call to contentResolver (document-store-api) to avoid getting still not existing content there #19

Merged
merged 1 commit into from
Aug 8, 2019

Conversation

gkazakov111
Copy link
Contributor

No description provided.

main_test.go Outdated Show resolved Hide resolved
Copy link

@rnov rnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as we agreed, all defer calls must handle errors a candidates to check :

./forwarder/forwarder.go:48:	defer resp.Body.Close()
./forwarder/forwarder_test.go:35:		defer r.Body.Close()
./forwarder/forwarder_test.go:57:	defer mockServer.Close()
./forwarder/forwarder_test.go:68:	defer mockServer.Close()
./forwarder/forwarder_test.go:80:	defer mockServer.Close()
./relations/relationsResolver_test.go:24:	defer file.Close()
./relations/relationsResolver.go:33:	defer resp.Body.Close()
./healthcheck.go:129:	defer resp.Body.Close()
./common_test.go:50:	defer file.Close()
./unfolder.go:73:	defer req.Body.Close()
./unfolder_test.go:32:	defer server.Close()
./unfolder_test.go:54:	defer server.Close()
./unfolder_test.go:65:	defer resp.Body.Close()
./unfolder_test.go:86:	defer server.Close()
./unfolder_test.go:100:	defer resp.Body.Close()
./unfolder_test.go:127:	defer server.Close()
./unfolder_test.go:151:	defer resp.Body.Close()
./unfolder_test.go:176:	defer server.Close()
./unfolder_test.go:201:	defer resp.Body.Close()
./unfolder_test.go:230:	defer server.Close()
./unfolder_test.go:254:	defer resp.Body.Close()
./unfolder_test.go:285:	defer server.Close()
./unfolder_test.go:315:	defer resp.Body.Close()
./unfolder_test.go:345:	defer server.Close()
./unfolder_test.go:378:	defer resp.Body.Close()
./unfolder_test.go:404:	defer server.Close()
./unfolder_test.go:443:	defer resp.Body.Close()
./unfolder_test.go:461:	defer server.Close()
./unfolder_test.go:485:	defer resp.Body.Close()
./resolver/contentResolver.go:34:	defer resp.Body.Close()
./resolver/contentResolver.go:113:	defer resp.Body.Close()
./resolver/contentResolver_test.go:30:	defer file.Close()
./resolver/uuidResolver_test.go:86:	defer file.Close()
./main_test.go:39:	defer writerServer.Close()
./main_test.go:42:	defer contentResolverServer.Close()
./main_test.go:45:	defer relationsResolverServer.Close()
./main_test.go:52:	defer unfolderServer.Close()
./main_test.go:59:	defer resp.Body.Close()
./main_test.go:79:	defer writerServer.Close()
./main_test.go:82:	defer contentResolverServer.Close()
./main_test.go:85:	defer relationsResolverServer.Close()
./main_test.go:92:	defer unfolderServer.Close()
./main_test.go:99:	defer resp.Body.Close()
./main_test.go:119:	defer writerServer.Close()
./main_test.go:122:	defer contentResolverServer.Close()
./main_test.go:125:	defer relationsResolverServer.Close()
./main_test.go:132:	defer unfolderServer.Close()
./main_test.go:138:	defer resp.Body.Close()
./main_test.go:161:		defer r.Body.Close()
./main_test.go:67:	json.Unmarshal(body, &healthResult)
./main_test.go:107:	json.Unmarshal(body, &healthResult)

@@ -19,6 +19,7 @@ type serviceConfig struct {
kafkaAddr *string
kafkaHostname *string
kafkaAuth *string
requestTimeout *int
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the point in general to use pointers for unmutable values like string or ints ?

@coveralls
Copy link

coveralls commented Jul 29, 2019

Coverage Status

Coverage decreased (-4.04%) to 78.78% when pulling f7c045a on fix/UPPSF-131-different-notifs-count-EU-US into c8ec645 on master.

rnov
rnov previously approved these changes Jul 31, 2019
fixed EOL's and a number

Added:
 - parameterised waiting interval in the call to contentResolver (document-store-api) to avoid getting still not existing content there
 - test updated and checked for not having races

* Removed an alias in config file

fixed one failing test
@gkazakov111 gkazakov111 force-pushed the fix/UPPSF-131-different-notifs-count-EU-US branch from 75b07dc to f7c045a Compare August 8, 2019 10:19
@gkazakov111 gkazakov111 merged commit 8e309e7 into master Aug 8, 2019
@mchompalova mchompalova deleted the fix/UPPSF-131-different-notifs-count-EU-US branch August 10, 2020 14:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants