-
Notifications
You must be signed in to change notification settings - Fork 4
CI-470 Extract width from video.scss #131
CI-470 Extract width from video.scss #131
Conversation
Do we need to consider how the other consumers of this package might be impacted? |
We do, I've mentioned some repos it might affect on the description in the |
I suppose if we're confident we could add the instructions of what to check and update to the release notes as this'll be a breaking change, then this'd delegate that decision making to people using this dependency. Might be worth checking with Josh what we should be recommending people update the presentation to be. |
I think this is fine, the width of a video is granular style that probably shouldn't be decided by a global component used by multiple consumers. If we release this as a breaking change and document what breaks in the release notes then that should be ok. We can then just update the apps we care about to the latest version |
@GlynnPhillips @NickColley I've updated the migration guide in the readme, let me know if the wording sounds correct 🙏 |
README.md
Outdated
@@ -26,6 +26,17 @@ plus common / utility classes used across article elements | |||
|
|||
## Migration guides | |||
|
|||
### v9 to v10 | |||
|
|||
v10 moves the responsibility of setting the width of embedded YouTube videos to the consumer, in relation to the 'n-content-video--youtube' class. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that we've confirmed that the decisions decision is to have full width videos across FT.com we could consider re-wording this so people know they don't need to make a change.
We can keep the steps below if they do need to bring back the previous behaviour for some reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, looking into it now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks. 👍🏻
Ticket.
YouTube videos are to be used with different widths in different places, so this PR extracts the width from the component so that we can set it where we use the component, giving greater flexibility.
To test:
Needs to go live at the same time as this PR.