Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

CI-470 Extract width from video.scss #131

Merged
merged 3 commits into from
Feb 18, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,17 @@ plus common / utility classes used across article elements

## Migration guides

### v9 to v10

v10 removes the width of embedded YouTube videos, in relation to the 'n-content-video--youtube' class. This is a design decision to make embedded YouTube videos consistently full-width. If you would like to replicate the old behaviour, you will have to set the width in the consumer repo.

Below is an example of how to replicate the old behaviour:
```
.n-content-video--youtube {
width: 560px;
}
```

### v8 to v9

v9 upgrades its version of `n-ui-foundations` from ^4.0.0 to ^6.0.0.
Expand Down
4 changes: 0 additions & 4 deletions scss/_video.scss
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,6 @@
width: 680px;
}

.n-content-video--youtube {
width: 560px;
}

.n-content-video__placeholder {
padding-top: 56.25%;

Expand Down