This repository has been archived by the owner on Apr 1, 2020. It is now read-only.
feat(tracking): track segmentID if cookie is present #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithamus
force-pushed
the
track-segment-id
branch
from
00de691
to
559e0d4
Compare
|
Looks OK to me. You may want to check that the segID also gets added to tracking of any click events etc (not sure if that falls through automatically from oTracking init) |
|
👍 |
| @@ -64,6 +64,9 @@ const oTrackingWrapper = { | |||
|
|
|||
| const edition = document.querySelector('[data-next-edition]') ? document.querySelector('[data-next-edition]').getAttribute('data-next-edition') : null; | |||
| context.edition = edition; | |||
| if (/(?:^|;)\s*segmentID=([^;]+)/.test(document.cookie)) { | |||
| context.segmentID = RegExp['$1']; | |||
There was a problem hiding this comment.
Ohhh, didn't know about this. Is it safe? (just going by the big 'Non-standard' warning at the top of https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/n)
This change detects if the `segmentID` cookie is present, and, if so, adds it to the o-tracking context object, so that it is tracked for all events on the page. segmentID is set as a session cookie, and is not always present. segmentID is used for campaign tracking for inbound ads, through - for example - facebook ads. We need to track segmentID so we can attach anonymous user journeys to particular campaigns.
keithamus
force-pushed
the
track-segment-id
branch
from
559e0d4
to
662e30f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change detects if the
segmentIDcookie is present, and, if so, adds it to the o-tracking context object, so that it is tracked for all events on the page. segmentID is set as a session cookie, and is not always present.segmentID is used for campaign tracking for inbound ads, through - for example - facebook ads. We need to track segmentID so we can attach anonymous user journeys to particular campaigns.
Based on git blame data, I'm going to ping @wheresrhys, @GlynnPhillips and @commuterjoy for anyone who fancies reviewing. I'm also going to ping @ironsidevsquincy @matthew-andrews who I've spoken to about the requirements for this. @matthew-andrews also suggests @i-like-robots as a potential reviewer.