This repository has been archived by the owner on Apr 1, 2020. It is now read-only.
don't output buttons in head css #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leafrogers
added a commit
that referenced
this pull request
Sep 16, 2016
* master: (24 commits) `&&` disappears from the terminal when echoed (#206) added maybe alias to nUiCritical to remind users that it's configurable (#440) Revert "don't output buttons in head css" (#439) don't output buttons in head css (#438) tweaked css build for more accurate metrics tweaked css build for more accurate metrics better purge fail logging removed simple from critical header styles (#435) Remove irrelevant tests Fix linting Fix homepage site/zone force latest o-video Remove drawer and sticky header from critical css (#431) Sticky-right-rail ad - refactor to work with sticky-banner Sticky-right-rail ad - refactor to work with sticky-banner Sticky-right-rail ad - refactor to work with sticky-banner Sticky-right-rail ad - refactor to work with sticky-banner Sticky-right-rail ad - refactor to work with sticky-banner Sticky-right-rail ad - refactor to work with sticky-banner Sticky-right-rail ad - refactor to work with sticky-banner ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only use the classes for stream page pagination and a handful of places in myft-page.
In v3 I think we should stop outputting button classes, but for now this hack at least takes them out of the critical path
@i-like-robots