Skip to content
This repository has been archived by the owner on Nov 26, 2021. It is now read-only.

Possible values for $o-assets-global-path? #17

Closed
kaelig opened this issue Mar 26, 2015 · 4 comments
Closed

Possible values for $o-assets-global-path? #17

kaelig opened this issue Mar 26, 2015 · 4 comments
Assignees
Milestone

Comments

@kaelig
Copy link
Contributor

kaelig commented Mar 26, 2015

The code mentions:

        // defaults to use module name
        $full-path: $module + '/' + $full-path;
        // Only add the global path if a custom path hasn't been set
        @if ($o-assets-global-path) {
            $full-path: $o-assets-global-path + $full-path;
        }

Unfortunately I couldn't find any occurrences where $o-assets-global-path could be false or null.

…so it looks like an artifact of the past that should now be:

        // defaults to use module name
        $full-path: $o-assets-global-path + $module + '/' + $full-path;

Thoughts?

@AlbertoElias
Copy link

I guess if there if it's empty, which is the same as what you think it should be, so I think we can change it

@kaelig
Copy link
Contributor Author

kaelig commented Mar 30, 2015

Cheers, I'll make that happen in v2

@kaelig kaelig added this to the 2.0.0 milestone Mar 30, 2015
@kaelig kaelig self-assigned this Mar 30, 2015
@kaelig
Copy link
Contributor Author

kaelig commented Apr 1, 2015

Removed in v2

@kaelig kaelig closed this as completed Apr 1, 2015
@triblondon
Copy link
Contributor

I was unsure about this, but chatted to Kaelig about it and I can't figure out what the code was doing before. Plus we didn't have any tests so it's hard to argue it was critical.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants