This repository has been archived by the owner on Nov 18, 2021. It is now read-only.
Remove o-header-services and o-footer-services dependencies #34
Comments
notlee
added a commit
that referenced
this issue
Dec 14, 2018
- Resolves conflict with the Origami spec (outputting CSS classes for a different component). - Does not include CSS which isn't needed (o-footer-services is not always used). - o-layout is nore flexible (any header or o-header-services version can be used). - Closes issue: #34
notlee
added a commit
that referenced
this issue
Dec 17, 2018
* Remove o-header-services and o-footer-services as dependancies. - Resolves conflict with the Origami spec (outputting CSS classes for a different component). - Does not include CSS which isn't needed (o-footer-services is not always used). - o-layout is nore flexible (any header or o-header-services version can be used). - Closes issue: #34 * Remove footer logo. o-footer-services currently requires a manual build step for a logo.
notlee
added a commit
that referenced
this issue
Dec 17, 2018
- Resolves conflict with the Origami spec (outputting CSS classes for a different component). - Does not include CSS which isn't needed (o-footer-services is not always used). - o-layout is nore flexible (any header or o-header-services version can be used). - Closes issue: #34
|
Done in v3. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
As far as I can tell,
o-header-servicessetssource=layoutto the logo's Image Service url, but beyond that I don't see the reason why we have this dependency.As for
o-footer-services, we include it, but don't do anything with it 🤔The text was updated successfully, but these errors were encountered: