Skip to content
This repository has been archived by the owner on Nov 26, 2021. It is now read-only.

Make $o-normalise-focus-color optional. #40

Closed
notlee opened this issue May 24, 2019 · 1 comment
Closed

Make $o-normalise-focus-color optional. #40

notlee opened this issue May 24, 2019 · 1 comment
Labels
breaking Will require a major version bump

Comments

@notlee
Copy link
Contributor

notlee commented May 24, 2019 •
edited
Loading

We shouldn't output a custom focus style for the whitelabel brand by default. We are currently using oxford-80, although it is not part of the whitelabel pallet.

In the next breaking consider allowing $o-normalise-focus-color to be null. Don't output focus styles if it is and use the browser default.
@notlee notlee added the breaking Will require a major version bump label May 24, 2019
@notlee notlee mentioned this issue Sep 3, 2019
Merged
notlee added a commit that referenced this issue Sep 3, 2019
@notlee
Make the focus colour branded and optional by using o-colors.
4f2c459 
Address:
- #40
- #35

Relates to:
- Financial-Times/o-colors#201
notlee added a commit that referenced this issue Sep 3, 2019
@notlee
Make the focus colour branded and optional by using o-colors.
b63555c 
Address:
- #40
- #35

Relates to:
- Financial-Times/o-colors#201
@notlee notlee mentioned this issue Sep 3, 2019
Merged
@notlee
Copy link
Contributor Author

notlee commented Sep 3, 2019

This is done, to be released as part of the breaking cascade. Closing to keep track of progress.

Related issue: #44
Related PR: #44

@notlee notlee closed this as completed Sep 3, 2019
notlee added a commit that referenced this issue Nov 21, 2019
@notlee
Make the focus colour branded and optional by using o-colors.
ff26e5d 
Address:
- #40
- #35

Relates to:
- Financial-Times/o-colors#201
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
breaking Will require a major version bump
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@notlee