Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: small button icon size and icon-only ratio (square) #1654

Merged
merged 2 commits into from
May 20, 2024

Conversation

notlee
Copy link
Contributor

@notlee notlee commented May 20, 2024

Before / After:
Screenshot 2024-05-20 at 11 54 06

Small, icon only button now aligns with our designs:

  • Square
  • 20px icon

Screenshot 2024-05-20 at 11 54 24

@notlee notlee requested a review from a team as a code owner May 20, 2024 10:55
@notlee notlee temporarily deployed to origami-webs-button-sma-r6f7g5 May 20, 2024 10:59 Inactive
@notlee notlee temporarily deployed to origami-webs-button-sma-r6f7g5 May 20, 2024 11:03 Inactive
@notlee
Copy link
Contributor Author

notlee commented May 20, 2024

Second commit correctly sets the inline padding to 16px for the default button
Screenshot 2024-05-20 at 12 03 24

Copy link
Contributor

@akomiqaia akomiqaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@notlee notlee merged commit 5bbbac1 into main May 20, 2024
7 checks passed
@notlee notlee deleted the button-small-icon-OR-377 branch May 20, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants