feat: add preview element #1676
Conversation
| encoding: 'utf8', | ||
| }); | ||
|
|
||
| const regex = /\/\/\s*<preview>([\s\S]*?)\/\/\s*<\/preview>/; |
There was a problem hiding this comment.
Between preview comments this matches on white-space and non-white-space – effectively anything (visualisation)
Could we make it a little simpler with?
/\/\/\s*<preview>(.*?)\/\/\s*<\/preview>/
There was a problem hiding this comment.
I think it's a very tiny detail that people might miss and let's why I included it so if someone doesn't use space between comments than it will still work
There was a problem hiding this comment.
I think we're talking about different things. My point was we could write ([\s\S]*?) as (.*?) and I believe get the same result
There was a problem hiding this comment.
oh i see :D sorry i thought you meant different thing
There was a problem hiding this comment.
Actualllllllyyy.... it looks like . doesn't capture line breaks where \s\S I think will, that's something to watch out for, maybe ignore this.
Describe your changes
Add preview component for astro web page
Issue ticket number and link
OR-717
Checklist before requesting a review