Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x-follow-button #59

Merged
merged 36 commits into from
Dec 4, 2019
Merged

x-follow-button #59

merged 36 commits into from
Dec 4, 2019

Commits on Nov 14, 2019

  1. Original development of x-follow-button using x-interaction (largely … 

    …obsolete).
    @kateloschinina
    Katerina authored and kateloschinina committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    41eaed9 View commit details
    Browse the repository at this point in the history

  2. Set main entry in bower.json to enable imports via Bower to resolve. … 

    …(+1 squashed commit)

Squashed commits:
[c641ec3b] update snapshot
    @kateloschinina
    Katerina authored and kateloschinina committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    9709478 View commit details
    Browse the repository at this point in the history

  3. Tidy up after rebase.

    @kateloschinina
    Dan Searle authored and kateloschinina committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    ef56c8a View commit details
    Browse the repository at this point in the history

  4. Update knobs for Storybook 4 (+1 squashed commit) 

    Squashed commits:
[feec44f8] More cleanup after rebase.
    @kateloschinina
    Dan Searle authored and kateloschinina committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    92b229f View commit details
    Browse the repository at this point in the history

  5. Dispatch custom event on click of button. Expose more meaningful acti… 

    …ons. No need for a separate onClick handler.
    @kateloschinina
    Dan Searle authored and kateloschinina committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    d9adab3 View commit details
    Browse the repository at this point in the history

  6. Remove data-myft-ui to prevent n-myft-ui generic button handling. (+1… 

    … squashed commit)

Squashed commits:
[4fbe12fc] Add displayName to base component
    @kateloschinina
    Dan Searle authored and kateloschinina committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    93873f4 View commit details
    Browse the repository at this point in the history

  7. Refactor to not use x-interaction. Also simplify the button as it now… 

    … expects to get rendered by its parent in order to change its state.
    @dan-searle @kateloschinina
    dan-searle authored and kateloschinina committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    bfe622c View commit details
    Browse the repository at this point in the history

  8. Use classnames package to apply component classes. Ensure specified v… 

    …ariant is supported.
    @dan-searle @kateloschinina
    dan-searle authored and kateloschinina committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    3bf8403 View commit details
    Browse the repository at this point in the history

  9. Remove x-interaction dependency.

    @dan-searle @kateloschinina
    dan-searle authored and kateloschinina committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    48b3081 View commit details
    Browse the repository at this point in the history

  10. Remove focus outline.

    @dan-searle @kateloschinina
    dan-searle authored and kateloschinina committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    1175d5a View commit details
    Browse the repository at this point in the history

  11. Only run bower install on prepare

    @dan-searle @kateloschinina
    dan-searle authored and kateloschinina committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    bb517bc View commit details
    Browse the repository at this point in the history

  12. don't display concept name in button text as a default

    @fenglish @kateloschinina
    fenglish authored and kateloschinina committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    1c52108 View commit details
    Browse the repository at this point in the history

  13. update snapshot tests

    @fenglish @kateloschinina
    fenglish authored and kateloschinina committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    6d7de7c View commit details
    Browse the repository at this point in the history

  14. update node-sass

    @fenglish @kateloschinina
    fenglish authored and kateloschinina committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    dbbb615 View commit details
    Browse the repository at this point in the history

  15. useConceptNameAsButtonText => conceptNameAsButtonText

    @fenglish @kateloschinina
    fenglish authored and kateloschinina committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    b1ab83e View commit details
    Browse the repository at this point in the history

  16. modify explanation of conceptNameAsButtonText

    @fenglish @kateloschinina
    fenglish authored and kateloschinina committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    acc728c View commit details
    Browse the repository at this point in the history

  17. conceptNameAsButtonText as a knob not a separated story

    @fenglish @kateloschinina
    fenglish authored and kateloschinina committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    8427d7c View commit details
    Browse the repository at this point in the history

  18. update snapshot tests

    @fenglish @kateloschinina
    fenglish authored and kateloschinina committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    165f04c View commit details
    Browse the repository at this point in the history

  19. eslintignore tools/x-docs/static/**

    @fenglish @kateloschinina
    fenglish authored and kateloschinina committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    fcdf405 View commit details
    Browse the repository at this point in the history

  20. MyFT => myFT

    @fenglish @kateloschinina
    fenglish authored and kateloschinina committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    493414b View commit details
    Browse the repository at this point in the history

  21. update snapshots

    @fenglish @kateloschinina
    fenglish authored and kateloschinina committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    35fe36c View commit details
    Browse the repository at this point in the history

  22. add subjectName in event.detail

    @fenglish @kateloschinina
    fenglish authored and kateloschinina committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    651eb75 View commit details
    Browse the repository at this point in the history

  23. revert the commit to add subjectName in event.detail

    @fenglish @kateloschinina
    fenglish authored and kateloschinina committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    7cfb279 View commit details
    Browse the repository at this point in the history

  24. Modify the followed button text

    @fenglish @kateloschinina
    fenglish authored and kateloschinina committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    86ac883 View commit details
    Browse the repository at this point in the history

  25. Remove CSS comments 

    ...as they cause issues when other components import these styles using CSS modules :global
    @dan-searle @kateloschinina
    dan-searle authored and kateloschinina committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    240650f View commit details
    Browse the repository at this point in the history

  26. More useful readme

    @dan-searle @kateloschinina
    dan-searle authored and kateloschinina committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    b6e7832 View commit details
    Browse the repository at this point in the history

  27. Not enough knobs to make it worth splitting them into groups.

    @dan-searle @kateloschinina
    dan-searle authored and kateloschinina committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    bfdbe7c View commit details
    Browse the repository at this point in the history

  28. Added onClick prop to X-Follow-Button

    @kateloschinina
    Pavel Pichrt authored and kateloschinina committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    8eec75d View commit details
    Browse the repository at this point in the history

  29. renamed onClick prop to onSubmit

    @kateloschinina
    Pavel Pichrt authored and kateloschinina committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    537f1f1 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2019

  1. Add x-follow-button to the new story format 

    Post the update whilst rebasing to master
    @kateloschinina
    kateloschinina committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    53c1f5a View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2019

  1. Update snapshot

    @kateloschinina
    kateloschinina committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    e9338da View commit details
    Browse the repository at this point in the history

  2. Refactor x-follow-button storybook demo 

     - Use regular story configuration
 - Clean code from the old-styled stories
    @kateloschinina
    kateloschinina committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    21a1cc0 View commit details
    Browse the repository at this point in the history

  3. Add tests 

     - Test conditional behaviour
 - Modify jest configuration to accomodate tests in the new
setup
    @kateloschinina
    kateloschinina committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    4b5843b View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2019

  1. Use sass-loader in storybook webpack 

    So that we can use Sass in components. This also adds all the bower
paths to the sass load path. Which works for the moment but might need
making more robust in the future.
    @edds
    edds committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    4ae4119 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into follow-button

    @edds
    edds committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    04d7890 View commit details
    Browse the repository at this point in the history

  3. Update x-follow-button for origami major change 

    So that we can include it in projects that use other components that use
the latest changes.
    @edds
    edds committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    f7474c7 View commit details
    Browse the repository at this point in the history