Skip to content
This repository has been archived by the owner on Nov 20, 2018. It is now read-only.

Odd behaviour when trying to remove an image in gallery mode #1417

Closed
smacode opened this issue Jun 4, 2015 · 10 comments
Closed

Odd behaviour when trying to remove an image in gallery mode #1417

smacode opened this issue Jun 4, 2015 · 10 comments

Comments

@smacode
Copy link

smacode commented Jun 4, 2015

For
Chrome 43.0.2357.81 m
Opera 29.0.1795.60

Two cases:
when Fine Uploader element is placed

  1. outside of form
    No request is sent after trash button has been clicked
  2. inside form
    The behaviour is as if you have clicked submit button

In Firefox 38.0.5 and IE 10.0.9200.16866 - OK

@rnicholus
Copy link
Member

Most likely due to the close button lacking a type="button". Adding that should fix the 2nd issue. Not sure what is causing the first issue for you. You'll have to show your code.

@rnicholus rnicholus added this to the 5.2.2 milestone Jun 4, 2015
@rnicholus
Copy link
Member

Issue 2 will be addressed by updating the default templates to include type="button" on all <button>s in the upcoming hotfix release. I'm unable to reproduce the first issue though, so without your code and some ability to reproduce it, I will be unable to look into it any further.

@rnicholus
Copy link
Member

Working on this now as part of 5.2.2. After the second issue in the report is addressed, 5.2.2 will be pushed out as a hotfix release.

@rnicholus
Copy link
Member

I'm unable to reproduce either issue. Please provide your code, a list of steps required to reproduce, and the specific issue(s) you are seeing.

@rnicholus
Copy link
Member

Nevermind, I am able to reproduce by uploading a file and then clicking the delete icon. I mistakenly thought you were removing images with autoUpload set to false before triggering the upload process.

@smacode
Copy link
Author

smacode commented Jun 5, 2015

Sorry, there was no opportunity to answer immediately.
I can reproduce described behaviour only with
fine-uploader.js (5.1.3)
fine-uploader-gallery.css (5.2.1)
gallery template (5.2.1)
Do you need any sources now?

@rnicholus
Copy link
Member

Are you saying that you are using the 5.1 version of the JavaScript file with a gallery template and the 5.2 version of the CSS file? If so, that is completely unsupported and you likely will have issues. The gallery view requires you use at least v5.2 of the JS file, since it wasn't introduced until 5.2.

@rnicholus
Copy link
Member

...more specific to your case, one of the changes in 5.2 included an adjustment to th click handler code, which was needed for the gallery view. That might explain your first issue. As a matter of course, the JS and CSS/template files should be of the same version.

@smacode
Copy link
Author

smacode commented Jun 5, 2015

Such ood configuration came out after some experements.
And I noticed that only when creted new clear test project
to reproduce described behaviour.

@rnicholus
Copy link
Member

Ok. So the first issue is expected, and should be resolved by using all 5.2 components in your project. All other issues you filed should be fixed in the hotfix/5.2.2 branch and will be released in the very near future, possibly today or Monday.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants