Skip to content
This repository has been archived by the owner on Nov 20, 2018. It is now read-only.

Problems with thumbnails generation after deleting items #1419

Closed
smacode opened this issue Jun 5, 2015 · 19 comments
Closed

Problems with thumbnails generation after deleting items #1419

smacode opened this issue Jun 5, 2015 · 19 comments

Comments

@smacode
Copy link

smacode commented Jun 5, 2015

  1. Drop dozen images
  2. Delete one before thumbnail generation finished for all items.
    At this step in IE and Firefox thumbnail generation stops for some items.
  3. Continue deleting and delete all items
  4. Drop that images again - no thumbnail is generated

Checked in:
Firefox 38.0.5
Chrome 43.0.2357.81 m
Opera 29.0.1795.60
IE 10.0.9200.16866

with Fine Uploader 5.2.1

@rnicholus
Copy link
Member

Likely a duplicate of #1416. If you are still seeing the issue in 5.2.2, I'll re-open.

@smacode
Copy link
Author

smacode commented Jun 5, 2015

The situations are different.
In #1416 you exclude
item that has not been uploaded.
In this issue you delete item that has been already uploaded.

@rnicholus
Copy link
Member

Are you able to reproduce this with the 5.2.2 version? The upload status of the file should not be relevant here.

@smacode
Copy link
Author

smacode commented Jun 5, 2015

At
http://fineuploader.com/customize.html
I see "Download 5.2.1" button.

@rnicholus
Copy link
Member

Yes, 5.2.2 hasn't been released yet. Regardless, I was finally able to reproduce this in firefox using the 5.2.2 code. I'm looking into this further now.

@rnicholus rnicholus reopened this Jun 5, 2015
@rnicholus rnicholus added this to the 5.2.2 milestone Jun 5, 2015
@rnicholus
Copy link
Member

I'm able to reproduce in any modern browser that is capable of client-side preview generation, and the gallery template is not required as far as I can tell. Only a "preview" element in the template.

This also uncovered another issue which is fairly minor but I will fix as well. An attempt is made to "update" the preview after a file has uploaded successfully, even if there is no thumbnailUrl in the response and client-side preview generation is possible.

@rnicholus
Copy link
Member

I think I have a fix for this. If you'd like to verify that I've fixed all of the issues you've reported in the last couple days (#1416, #1417, #1418, and #1419) before I release 5.2.2, I can get you the pre-release.

@smacode
Copy link
Author

smacode commented Jun 8, 2015

Ok, I'm waiting for pre-release.

@rnicholus
Copy link
Member

S3, azure, or a custom endpoint you control?

On Mon, Jun 8, 2015 at 3:03 AM micmicovich notifications@github.com wrote:

Ok, I'm waiting for pre-release.


Reply to this email directly or view it on GitHub
#1419 (comment)
.

@smacode
Copy link
Author

smacode commented Jun 8, 2015

Custom endpoint

@rnicholus
Copy link
Member

@smacode
Copy link
Author

smacode commented Jun 8, 2015

Looking into it now.

@rnicholus
Copy link
Member

I plan on releasing 5.2.2 tomorrow morning (Central Time) unless I hear that there are additional issues caused by these fixes. I didn't see any.

@smacode
Copy link
Author

smacode commented Jun 9, 2015

There are additional issues. Please, wait a little

@smacode
Copy link
Author

smacode commented Jun 9, 2015

All issues (#1416, #1417, #1418, and #1419) - ок.

When I begun to test, I faced the problem,
that later was hard to reproduce.
Problem:
thumbnail generation stops at some item (more often closer to the end of list).
How to reproduce:

  • Firefox 38.0.5
  • a lot of open tabs (~30)
  • number of images: 36
  • image size: 1-2 Mb
  • Fine Uploader element outside of form
  • a little of free system memory
  • CPU: high loaded (not necessarily)

But if thumbnail was not generated for even one item,
after deleting all items and uploading them again,
no thumbnail is generated.

@rnicholus
Copy link
Member

This does not sound like a new issue, nor does it sound like one that will
be easily reproduced. I'll see if I can reproduce, and if I am unable to do
so in a reasonable amount of time, I don't see this holding up the hotfix
release.
On Tue, Jun 9, 2015 at 4:14 AM micmicovich notifications@github.com wrote:

All issues (#1416
#1416, #1417
#1417, #1418
#1418, and #1419
#1419) - ок.

When I begun to test, I faced the problem,
that later was hard to reproduce.
Problem:
thumbnail generation stops at some item (more often closer to the end of
list).
How to reproduce:

  • Firefox 38.0.5
  • a lot of open tabs (~30)
  • number of images: 36
  • image size: 1-2 Mb
  • Fine Uploader element outside of form
  • a little of system memory
  • CPU: high loaded (not necessarily)

But if thumbnail was not generated for even one item,
after deleting all items and uploading them again,
no thumbnail is generated.


Reply to this email directly or view it on GitHub
#1419 (comment)
.

@rnicholus
Copy link
Member

Also you'll need to quantify "a little of system memory".

@smacode
Copy link
Author

smacode commented Jun 9, 2015

I've edited the post: "a little of FREE system memory"
~350 Mb on Windows 7 Ultimate

@rnicholus
Copy link
Member

Please move all of this to a new case
On Tue, Jun 9, 2015 at 7:44 AM micmicovich notifications@github.com wrote:

I've edited the post: "a little of FREE system memory"
~350 Mb on Windows 7 Ultimate


Reply to this email directly or view it on GitHub
#1419 (comment)
.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants