Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coordinate labels (Cartesian, cylindrical, polar, spherical) #34

Merged
merged 33 commits into from
Mar 31, 2024

Conversation

mhvwerts
Copy link
Member

I have started implementing different coordinate labels for different mesh types (see #15) and successfully did this for FaceVariables (xvalue, rvalue and the like), as can be seen from the initial commits to this PR.

That, however, was the easy part.

The coordinates of the mesh objects themselves will be trickier to handle, I fear. Therefore, I will take this one step at a time, adding commits to this PR at each stage, so that you, @simulkade, can shine your light over it.

If successful, this will close #15.

@mhvwerts mhvwerts marked this pull request as draft March 27, 2024 15:27
@mhvwerts mhvwerts requested a review from simulkade March 27, 2024 15:28
@mhvwerts mhvwerts marked this pull request as ready for review March 29, 2024 22:13
@mhvwerts mhvwerts changed the title WIP: Coordinate labels (Cartesian, cylindrical, polar, spherical) Coordinate labels (Cartesian, cylindrical, polar, spherical) Mar 29, 2024
Copy link
Member

@simulkade simulkade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of effort and contemplation has gone into it, @mhvwerts! Everything looks fine, as far as I could see during this short break from holidays :-).

src/pyfvtool/cell.py Show resolved Hide resolved
src/pyfvtool/face.py Show resolved Hide resolved
src/pyfvtool/mesh.py Show resolved Hide resolved
src/pyfvtool/utilities.py Show resolved Hide resolved
@simulkade simulkade merged commit 6e31586 into FiniteVolumeTransportPhenomena:main Mar 31, 2024
@mhvwerts
Copy link
Member Author

mhvwerts commented Apr 2, 2024

Thanks for being so responsive. I am happy that I did this. I agree with you about the positive effects of this Python therapy. I feel better now! Also, PyFVTool is now better adapted to our (cylindrical) research project here, so it was timely for me to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Labeling of coordinates in cylindrical (and spherical) meshes
2 participants