Coordinate labels (Cartesian, cylindrical, polar, spherical) #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhvwerts
changed the title
simulkade
reviewed
Mar 31, 2024
simulkade
reviewed
Mar 31, 2024
|
Thanks for being so responsive. I am happy that I did this. I agree with you about the positive effects of this Python therapy. I feel better now! Also, PyFVTool is now better adapted to our (cylindrical) research project here, so it was timely for me to do this. |
This was referenced Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have started implementing different coordinate labels for different mesh types (see #15) and successfully did this for
FaceVariables (xvalue,rvalueand the like), as can be seen from the initial commits to this PR.That, however, was the easy part.
The coordinates of the mesh objects themselves will be trickier to handle, I fear. Therefore, I will take this one step at a time, adding commits to this PR at each stage, so that you, @simulkade, can shine your light over it.
If successful, this will close #15.