Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coordinate labels (Cartesian, cylindrical, polar, spherical) #34

Merged
merged 33 commits into from
Mar 31, 2024
Merged

Coordinate labels (Cartesian, cylindrical, polar, spherical) #34

merged 33 commits into from
Mar 31, 2024

Commits on Mar 26, 2024

  1. SignedTuple class, for future reference

    @mhvwerts
    mhvwerts committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    6e74017 View commit details
    Browse the repository at this point in the history

  2. Entering the 'Upside Down': xvalue -> _xvalue etc. pytest OK.

    @mhvwerts
    mhvwerts committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    76f3013 View commit details
    Browse the repository at this point in the history

  3. xvalue, yvalue, zvalue as properties

    @mhvwerts
    mhvwerts committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    8849671 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. rvalue, zvalue for FaceVariable in cylindrical grids

    @mhvwerts
    mhvwerts committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    467168d View commit details
    Browse the repository at this point in the history

  2. thetavalue, phivalue as properties of FaceVariable

    @mhvwerts
    mhvwerts committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    c76ee47 View commit details
    Browse the repository at this point in the history

  3. reorganize

    @mhvwerts
    mhvwerts committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    8a96334 View commit details
    Browse the repository at this point in the history

  4. removed copyCellVariable already handled by CellVariable.copy() method

    @mhvwerts
    mhvwerts committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    31f855a View commit details
    Browse the repository at this point in the history

  5. get_CellVariable_profile1D -> CellVariable.plotprofile() method

    @mhvwerts
    mhvwerts committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    db8555b View commit details
    Browse the repository at this point in the history

  6. get_CellVariable_profile2D -> CellVariable.plotprofile() method

    @mhvwerts
    mhvwerts committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    e9635ba View commit details
    Browse the repository at this point in the history

  7. get_CellVariable_profile3D -> CellVariable.plotprofile() method

    @mhvwerts
    mhvwerts committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    1cc407a View commit details
    Browse the repository at this point in the history

  8. domainInt() -> CellVariable.domainIntegral()

    @mhvwerts
    mhvwerts committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    15ebbdb View commit details
    Browse the repository at this point in the history

  9. cellVolume -> cellVolumes variant

    @mhvwerts
    mhvwerts committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    ec02b03 View commit details
    Browse the repository at this point in the history

  10. keep cellLocations intact

    @mhvwerts
    mhvwerts committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    f5e3530 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. document coordinate labels

    @mhvwerts
    mhvwerts committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    cb96b62 View commit details
    Browse the repository at this point in the history

  2. Entering the Upside Down again...

    @mhvwerts
    mhvwerts committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    71c5183 View commit details
    Browse the repository at this point in the history

  3. internal .z becomes ._z

    @mhvwerts
    mhvwerts committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    515e296 View commit details
    Browse the repository at this point in the history

  4. internal .y becomes ._y

    @mhvwerts
    mhvwerts committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    6437f08 View commit details
    Browse the repository at this point in the history

  5. internal .x becomes _x (pytest OK)

    @mhvwerts
    mhvwerts committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    793415e View commit details
    Browse the repository at this point in the history

  6. docstrings for mesh classes and paving the way for conventional coord… 

    …inate labels
    @mhvwerts
    mhvwerts committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    4dfafca View commit details
    Browse the repository at this point in the history

  7. __str__() and __repr__() in mesh.py

    @mhvwerts
    mhvwerts committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    4144851 View commit details
    Browse the repository at this point in the history

  8. We have an 'x' coordinate label. Test script still needed.

    @mhvwerts
    mhvwerts committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    1774efd View commit details
    Browse the repository at this point in the history

  9. Bump version

    @mhvwerts
    mhvwerts committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    1f076b3 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. We have an 'r'.

    @mhvwerts
    mhvwerts committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    1622521 View commit details
    Browse the repository at this point in the history

  2. Consolidate before refactoring attempt

    @mhvwerts
    mhvwerts committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    1a7b24b View commit details
    Browse the repository at this point in the history

  3. Refactoring of CellSize, CellLocation, FaceLocation code.

    @mhvwerts
    mhvwerts committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    7111857 View commit details
    Browse the repository at this point in the history

  4. Non standard __repr__() for user-friendliness

    @mhvwerts
    mhvwerts committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    074ff9b View commit details
    Browse the repository at this point in the history

  5. We have a 'z'.

    @mhvwerts
    mhvwerts committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    67a1990 View commit details
    Browse the repository at this point in the history

  6. Fix docstring

    @mhvwerts
    mhvwerts committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    e9bd015 View commit details
    Browse the repository at this point in the history

  7. We have a 'y' (plus example scripts working with the new coord. labels)

    @mhvwerts
    mhvwerts committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    d766103 View commit details
    Browse the repository at this point in the history

  8. We have a 'theta' with pytest OK, but we do not test much yet.

    @mhvwerts
    mhvwerts committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    5825a37 View commit details
    Browse the repository at this point in the history

  9. We have a 'phi' (but again not much tested there).

    @mhvwerts
    mhvwerts committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    fc8fd19 View commit details
    Browse the repository at this point in the history

  10. The mesh coordinate labels should probably be read-only.

    @mhvwerts
    mhvwerts committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    5c0a79b View commit details
    Browse the repository at this point in the history

  11. Small correction.

    @mhvwerts
    mhvwerts committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    286248a View commit details
    Browse the repository at this point in the history