c: add unittest CI #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the already existing eslint configuration file, rules is set with warn. if it is not an error, it cannot be detected by ci, is it doesn’t problem? |
I don't know. Maybe it is setted as you said. But I don't know how can CI ignore this errors. |
loin3
reviewed
Apr 6, 2022
loin3
reviewed
Apr 6, 2022
loin3
approved these changes
Apr 6, 2022
shiki-tak
reviewed
Apr 6, 2022
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: '16' | ||
| - run: if [ ! -x "$(command -v yarn)" ]; then npm install -g yarn; fi |
There was a problem hiding this comment.
I am not familiar with self-hosted runner.
Isn't there a problem if I install yarn directly on a self-hosted machine?
There was a problem hiding this comment.
In general, I know that when we execute setup-node action, yarn is also installed. But, it was not actually installed, so I installed it directly.
shiki-tak
approved these changes
Apr 8, 2022
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relate: #6
This ci of github action execute all unittest.