feat: apply lbm-sdk v0.46.0-rc6 #32

zemyblue · 2022-07-31T06:40:31Z

apply lbm-sdk v0.46.0-rc6

Changes

remove unnecessary packages

The below packages is not necessary because the proto path of lbm-sdk has been changed to the same as that of cosmos-sdk.

amino
proto-signing
ostracon-rpc
faucet
faucet-client

Add `token` and `collection` module APIs

update the latest chagnes of token module.
add new collection module APIs

Add local simapp test script.

fix setup.sh of simapp script to generate genesis and config files with local simapp.
add the script to execute the local simapp.

Signed-off-by: zemyblue <zemyblue@gmail.com>

Signed-off-by: zemyblue <zemyblue@gmail.com> # Conflicts: # .pnp.cjs # packages/amino/src/signdoc.spec.ts # packages/cosmwasm-stargate/package.json # packages/cosmwasm-stargate/src/cosmwasmclient.searchtx.spec.ts # packages/cosmwasm-stargate/src/cosmwasmclient.spec.ts # packages/cosmwasm-stargate/src/signingcosmwasmclient.spec.ts # packages/cosmwasm-stargate/src/signingcosmwasmclient.ts # packages/cosmwasm-stargate/src/testutils.spec.ts # packages/faucet/src/tokenmanager.ts # packages/proto-signing/package.json # packages/proto-signing/src/decode.spec.ts # packages/proto-signing/src/decode.ts # packages/proto-signing/src/directsecp256k1hdwallet.ts # packages/proto-signing/src/directsecp256k1wallet.ts # packages/proto-signing/src/pubkey.spec.ts # packages/proto-signing/src/pubkey.ts # packages/proto-signing/src/registry.spec.ts # packages/proto-signing/src/registry.ts # packages/proto-signing/src/signer.ts # packages/proto-signing/src/signing.spec.ts # packages/proto-signing/src/signing.ts # packages/stargate/package.json # packages/stargate/src/accounts.spec.ts # packages/stargate/src/accounts.ts # packages/stargate/src/aminotypes.spec.ts # packages/stargate/src/modules/auth/queries.spec.ts # packages/stargate/src/modules/authz/messages.ts # packages/stargate/src/modules/authz/queries.spec.ts # packages/stargate/src/modules/bank/aminomessages.spec.ts # packages/stargate/src/modules/bank/aminomessages.ts # packages/stargate/src/modules/bank/messages.ts # packages/stargate/src/modules/collection/messages.ts # packages/stargate/src/modules/collection/queries.spec.ts # packages/stargate/src/modules/collection/queries.ts # packages/stargate/src/modules/distribution/queries.spec.ts # packages/stargate/src/modules/evidence/queries.spec.ts # packages/stargate/src/modules/feegrant/messages.ts # packages/stargate/src/modules/feegrant/queries.spec.ts # packages/stargate/src/modules/foundation/messages.ts # packages/stargate/src/modules/foundation/queries.spec.ts # packages/stargate/src/modules/gov/aminomessages.ts # packages/stargate/src/modules/gov/messages.ts # packages/stargate/src/modules/ibc/aminomessages.spec.ts # packages/stargate/src/modules/ibc/aminomessages.ts # packages/stargate/src/modules/ibc/messages.ts # packages/stargate/src/modules/staking/queries.spec.ts # packages/stargate/src/modules/token/messages.ts # packages/stargate/src/modules/token/queries.spec.ts # packages/stargate/src/modules/token/queries.ts # packages/stargate/src/modules/tx/queries.spec.ts # packages/stargate/src/modules/tx/queries.ts # packages/stargate/src/modules/vesting/messages.spec.ts # packages/stargate/src/modules/vesting/messages.ts # packages/stargate/src/multisignature.spec.ts # packages/stargate/src/multisignature.ts # packages/stargate/src/queryclient/queryclient.spec.ts # packages/stargate/src/signingstargateclient.spec.ts # packages/stargate/src/signingstargateclient.ts # packages/stargate/src/stargateclient.searchtx.spec.ts # packages/stargate/src/stargateclient.spec.ts # packages/stargate/src/stargateclient.ts # packages/stargate/src/testutils.spec.ts # scripts/simapp/template/.simapp/config/genesis.json # scripts/simapp/template/.simapp/config/gentx/gentx-1bfcd538a01ca3f88f71db61f83d84813ae4b721.json # scripts/simapp/template/.simapp/config/node_key.json # scripts/simapp/template/.simapp/config/priv_validator_key.json # scripts/simapp/template/.simapp/keyring-test/6c696e6b31343661736179636d7479647134356b78633865766e74716667657061677967656c656c303068.address # scripts/simapp/template/.simapp/keyring-test/6c696e6b31346e7676726b34647a336b363935743837343076717a6a6e767277737a776d36396877306c73.address # scripts/simapp/template/.simapp/keyring-test/6c696e6b316161666678647a346477636e6a7a756d6a6d37683839796a7735633577756c38387a767a7575.address # scripts/simapp/template/.simapp/keyring-test/6c696e6b3164667979776a676c636670746e37326178786873736c70793865703677713777756a61736d61.address # scripts/simapp/template/.simapp/keyring-test/6c696e6b316566707171766c75397076306865357438717666743935653864656c6866303577387a6b7a6a.address # scripts/simapp/template/.simapp/keyring-test/6c696e6b31657175346e33757779686170616b3567336c65713061767a38356b3071366a63647935773066.address # scripts/simapp/template/.simapp/keyring-test/6c696e6b316579307730786a39763438766b38326874366d6871646c683977716b7838656e6b706a777072.address # scripts/simapp/template/.simapp/keyring-test/6c696e6b3167303739323771356361386376776c32667836723865676b77366c616e783770333774787336.address # scripts/simapp/template/.simapp/keyring-test/6c696e6b3167376773676b746c39796a716174616373776c77766e7335797a793475356a6568737832707a.address # scripts/simapp/template/.simapp/keyring-test/6c696e6b31747773666d756a32386e64706835346b346e77386372777538683963386d6833727478373035.address # scripts/simapp/template/.simapp/keyring-test/account0.info # scripts/simapp/template/.simapp/keyring-test/account1.info # scripts/simapp/template/.simapp/keyring-test/account2.info # scripts/simapp/template/.simapp/keyring-test/account3.info # scripts/simapp/template/.simapp/keyring-test/account4.info # scripts/simapp/template/.simapp/keyring-test/account5.info # scripts/simapp/template/.simapp/keyring-test/account6.info # scripts/simapp/template/.simapp/keyring-test/account7.info # scripts/simapp/template/.simapp/keyring-test/account8.info # scripts/simapp/template/.simapp/keyring-test/multisig0.info # scripts/simapp/template/.simapp/keyring-test/validator0.info # scripts/simapp/template/setup.sh # yarn.lock

Signed-off-by: zemyblue <zemyblue@gmail.com>

packages/cosmwasm-stargate/src/cosmwasmclient.searchtx.spec.ts

loin3 · 2022-08-01T05:13:19Z

packages/cosmwasm-stargate/src/cosmwasmclient.searchtx.spec.ts

@@ -151,6 +155,8 @@ describe("CosmWasmClient.getTx and .searchTx", () => {
      }

      await sleep(75); // wait until transactions are indexed
+
+      client.disconnect();


In cosmjs this line is not exist. Do we need this line?

Yes, it need. Because if the client is not closed, the socket of chain is opened and don't close, and then if the request accumulate the chain doesn't response any more. no problem in Circle CI of cosmjs, but it has basically problem.

packages/cosmwasm-stargate/src/modules/wasm/queries.spec.ts

loin3

Currently in stargate package makeLinkPath function is located in src/queryclient/utils.ts, but like the cosmwasm-stargate package it would be nice to move the makeLinkPath function to path.ts.

Signed-off-by: zemyblue <zemyblue@gmail.com>

dudong2 · 2022-08-02T02:05:53Z

packages/stargate/src/modules/gov/queries.spec.ts

@@ -331,22 +332,22 @@ describe("GovExtension", () => {
      expect(response.votes).toEqual([
        Vote.fromPartial({
          proposalId: longify(proposalId),
-          voter: voter1Address,
-          option: VoteOption.VOTE_OPTION_YES,
+          voter: voter2Address,


Is any reason about changing voter1Address to voter2Address?

Because the order of array is changed. But the each data is not changed. I'll check why the order is changed.

dudong2 · 2022-08-02T02:06:09Z

packages/stargate/src/modules/gov/queries.spec.ts

              weight: "1000000000000000000",
            }),
          ],
        }),
        Vote.fromPartial({
          proposalId: longify(proposalId),
-          voter: voter2Address,
-          option: VoteOption.VOTE_OPTION_NO_WITH_VETO,
+          voter: voter1Address,


zemyblue added 17 commits July 20, 2022 21:43

chore: apply line/lbm-simapp:0.46.0-rc5

6222774

Signed-off-by: zemyblue <zemyblue@gmail.com>

feat: add collection module

b70d32d

Signed-off-by: zemyblue <zemyblue@gmail.com>

chore: remove build path import

e8da830

Signed-off-by: zemyblue <zemyblue@gmail.com>

chore: remove unnecessary packages.

e430344

Signed-off-by: zemyblue <zemyblue@gmail.com>

chore: update lock files.

6435689

Signed-off-by: zemyblue <zemyblue@gmail.com>

feat: apply the changing of ostracon's crypto key name

7d2c299

Signed-off-by: zemyblue <zemyblue@gmail.com>

feat: replace @lbmjs to @cosmjs

c0e672a

Signed-off-by: zemyblue <zemyblue@gmail.com>

remove ostracon-rpc package

3eee70e

Signed-off-by: zemyblue <zemyblue@gmail.com>

remove amino, proto-signing packages

84d87c2

Signed-off-by: zemyblue <zemyblue@gmail.com>

remove no need files.

b20489f

feat: apply the changes of token module APIs.

70daaeb

Signed-off-by: zemyblue <zemyblue@gmail.com>

chore: add all token query unittest.

2c7d0f0

Signed-off-by: zemyblue <zemyblue@gmail.com>

feat: update the changes of colelction module.

9c85a17

Signed-off-by: zemyblue <zemyblue@gmail.com>

chore: update package version.

c37155f

Signed-off-by: zemyblue <zemyblue@gmail.com>

chore: delete unused ostracon module in stargate.

2487b20

Signed-off-by: zemyblue <zemyblue@gmail.com>

chore: change simapp script env

aae4704

Signed-off-by: zemyblue <zemyblue@gmail.com>

zemyblue self-assigned this Jul 31, 2022

zemyblue requested review from 0Tech, dudong2 and loin3 July 31, 2022 06:41

loin3 reviewed Aug 1, 2022

View reviewed changes

chore: apply feedback

b06115f

Signed-off-by: zemyblue <zemyblue@gmail.com>

loin3 approved these changes Aug 1, 2022

View reviewed changes

dudong2 approved these changes Aug 2, 2022

View reviewed changes

torao approved these changes Aug 2, 2022

View reviewed changes

zemyblue merged commit 8f22dac into main Aug 2, 2022

zemyblue deleted the change_key_prefix_add_voting_power branch August 2, 2022 04:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: apply lbm-sdk v0.46.0-rc6 #32

feat: apply lbm-sdk v0.46.0-rc6 #32

zemyblue commented Jul 31, 2022

loin3 Aug 1, 2022

zemyblue Aug 1, 2022

loin3 left a comment

dudong2 Aug 2, 2022

zemyblue Aug 2, 2022

dudong2 Aug 2, 2022

feat: apply lbm-sdk v0.46.0-rc6 #32

feat: apply lbm-sdk v0.46.0-rc6 #32

Conversation

zemyblue commented Jul 31, 2022

Changes

remove unnecessary packages

Add token and collection module APIs

Add local simapp test script.

loin3 Aug 1, 2022

Choose a reason for hiding this comment

zemyblue Aug 1, 2022

Choose a reason for hiding this comment

loin3 left a comment

Choose a reason for hiding this comment

dudong2 Aug 2, 2022

Choose a reason for hiding this comment

zemyblue Aug 2, 2022

Choose a reason for hiding this comment

dudong2 Aug 2, 2022

Choose a reason for hiding this comment

Add `token` and `collection` module APIs