Skip to content

Commit

Permalink
chore: revert gRPC block height header. (#607)
Browse files Browse the repository at this point in the history
* chore: revert gRPC block height header.

Signed-off-by: zemyblue <zemyblue@gmail.com>

* docs: update changelog.

Signed-off-by: zemyblue <zemyblue@gmail.com>
  • Loading branch information
zemyblue committed Jul 26, 2022
1 parent 86bb7a8 commit 7cdbce7
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
* (x/collection) [\#571](https://github.com/line/lbm-sdk/pull/571) add x/collection proto
* (x/collection) [\#574](https://github.com/line/lbm-sdk/pull/574) implement x/collection
* (amino) [\600](https://github.com/line/lbm-sdk/pull/600) change amino codec path from `lbm-sdk/` to `cosmos-sdk/`
* (server/grpc) [\#607](https://github.com/line/lbm-sdk/pull/607) revert gRPC block height header.

### Improvements

Expand Down
2 changes: 1 addition & 1 deletion server/grpc/server_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ func (s *IntegrationTestSuite) TestGRPCServer_BroadcastTx() {
}

// Test and enforce that we upfront reject any connections to baseapp containing
// invalid initial x-lbm-block-height that aren't positive and in the range [0, max(int64)]
// invalid initial x-cosmos-block-height that aren't positive and in the range [0, max(int64)]
// See issue https://github.com/cosmos/cosmos-sdk/issues/7662.
func (s *IntegrationTestSuite) TestGRPCServerInvalidHeaderHeights() {
t := s.T()
Expand Down
2 changes: 1 addition & 1 deletion types/grpc/headers.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ package grpc

const (
// GRPCBlockHeightHeader is the gRPC header for block height.
GRPCBlockHeightHeader = "x-lbm-block-height"
GRPCBlockHeightHeader = "x-cosmos-block-height"
)

0 comments on commit 7cdbce7

Please sign in to comment.