fix: add non-zero check of nextTokenID.Id for genesis #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1276 +/- ##
==========================================
- Coverage 69.74% 69.74% -0.01%
==========================================
Files 643 643
Lines 67255 67261 +6
==========================================
+ Hits 46906 46909 +3
- Misses 18176 18179 +3
Partials 2173 2173
|
jaeseung-bae
requested review from
tkxkd0159,
zemyblue and
0Tech
as code owners
ulbqb
previously approved these changes
Mar 15, 2024
0Tech
requested changes
Mar 15, 2024
tkxkd0159
approved these changes
Mar 15, 2024
0Tech
approved these changes
Mar 15, 2024
170210
approved these changes
Mar 15, 2024
mergify bot
pushed a commit
that referenced
this pull request
Mar 15, 2024
* fix: add non-zero check of nextTokenID.Id for genesis * chore: add testcase * chore: update changelog * chore: move validation logic to validate function * chore: add testcase (cherry picked from commit 47a5e9f) # Conflicts: # CHANGELOG.md
5 tasks
jaeseung-bae
added a commit
that referenced
this pull request
Mar 19, 2024
#1282) * fix: add non-zero check of nextTokenID.Id for genesis (#1276) * fix: add non-zero check of nextTokenID.Id for genesis * chore: add testcase * chore: update changelog * chore: move validation logic to validate function * chore: add testcase (cherry picked from commit 47a5e9f) # Conflicts: # CHANGELOG.md * Update CHANGELOG.md Co-authored-by: 170210 <85928898+170210@users.noreply.github.com> * chore: update changelog --------- Co-authored-by: jaeseung-bae <119839167+jaeseung-bae@users.noreply.github.com> Co-authored-by: jaeseung.bae <jaeseung.bae@linecorp.com> Co-authored-by: 170210 <85928898+170210@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
tokenIDin GenesisMotivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml