build: set Finschia/ostracon version #1298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0Tech
requested review from
tkxkd0159,
zemyblue and
jaeseung-bae
as code owners
4 tasks
zemyblue
approved these changes
Mar 26, 2024
tkxkd0159
approved these changes
Mar 26, 2024
This was referenced Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extract the version of Finschia/ostracon from
go.modand set the flag on the build.Motivation and context
Finschia/ostracon does not set its version even in the release branches, while the upstream tendermint sets its version.
Hence, we won't apply this patch on the main, which uses tendermint already.
How has this been tested?
make build./build/simd ostracon versionScreenshots (if appropriate):
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml