Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use bytes instead of string comparison in delete validator queue (backport cosmos/cosmos-sdk#12303) #1301

Merged
merged 5 commits into from
Mar 26, 2024

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Mar 26, 2024

Description

Cherry-pick of:

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech added A: bug Something isn't working C:x/staking labels Mar 26, 2024
@0Tech 0Tech self-assigned this Mar 26, 2024
@CLAassistant
Copy link

CLAassistant commented Mar 26, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ 0Tech
❌ williamchong
You have signed the CLA already but the status is still pending? Let us recheck it.

@0Tech
Copy link
Collaborator Author

0Tech commented Mar 26, 2024

Please ignore CLA.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 70.43%. Comparing base (a7a39e5) to head (29cc88d).

❗ Current head 29cc88d differs from pull request most recent head b16ba19. Consider uploading reports for the commit b16ba19 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1301      +/-   ##
==========================================
- Coverage   70.43%   70.43%   -0.01%     
==========================================
  Files         643      643              
  Lines       54724    54726       +2     
==========================================
  Hits        38544    38544              
- Misses      14009    14010       +1     
- Partials     2171     2172       +1     
Files Coverage Δ
x/staking/keeper/validator.go 80.95% <50.00%> (-1.27%) ⬇️

... and 3 files with indirect coverage changes

@0Tech 0Tech marked this pull request as ready for review March 26, 2024 06:59
@0Tech
Copy link
Collaborator Author

0Tech commented Mar 26, 2024

Please ignore coverage on panic scenarios.

jaeseung-bae
jaeseung-bae previously approved these changes Mar 26, 2024
@0Tech 0Tech merged commit 1038a39 into Finschia:main Mar 26, 2024
32 of 33 checks passed
@0Tech 0Tech deleted the var-01 branch March 26, 2024 12:30
mergify bot pushed a commit that referenced this pull request Mar 26, 2024
… (backport cosmos/cosmos-sdk#12303) (#1301)

* fix : Use bytes instead of string comparison in delete validator queue (#12303)

* Update CHANGELOG.md

* Update CHANGELOG.md

---------

Co-authored-by: William Chong <6198816+williamchong@users.noreply.github.com>
(cherry picked from commit 1038a39)

# Conflicts:
#	CHANGELOG.md
0Tech added a commit that referenced this pull request Mar 29, 2024
… (backport cosmos/cosmos-sdk#12303) (backport #1301) (#1309)

* fix: Use bytes instead of string comparison in delete validator queue (backport cosmos/cosmos-sdk#12303) (#1301)

* fix : Use bytes instead of string comparison in delete validator queue (#12303)

* Update CHANGELOG.md

* Update CHANGELOG.md

---------

Co-authored-by: William Chong <6198816+williamchong@users.noreply.github.com>
(cherry picked from commit 1038a39)

# Conflicts:
#	CHANGELOG.md

* Update CHANGELOG.md

---------

Co-authored-by: Youngtaek Yoon <noreply@yoon.mailer.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants