fix: possible overflow in BuildUnsignedTx #1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1303 +/- ##
=======================================
Coverage 70.43% 70.43%
=======================================
Files 643 643
Lines 54720 54720
=======================================
Hits 38542 38542
Misses 14008 14008
Partials 2170 2170
|
jaeseung-bae
changed the title
jaeseung-bae
requested review from
tkxkd0159,
zemyblue and
0Tech
as code owners
0Tech
reviewed
Mar 26, 2024
0Tech
previously approved these changes
Mar 26, 2024
tkxkd0159
approved these changes
Mar 26, 2024
0Tech
approved these changes
Mar 26, 2024
mergify bot
pushed a commit
that referenced
this pull request
Mar 26, 2024
* fix: possible overflow * chore: update changelog * chore: add comment (cherry picked from commit b1c09cf) # Conflicts: # CHANGELOG.md
5 tasks
0Tech
added a commit
that referenced
this pull request
Mar 29, 2024
* fix: possible overflow in BuildUnsignedTx (#1303) * fix: possible overflow * chore: update changelog * chore: add comment (cherry picked from commit b1c09cf) # Conflicts: # CHANGELOG.md * Update CHANGELOG.md --------- Co-authored-by: jaeseung-bae <119839167+jaeseung-bae@users.noreply.github.com> Co-authored-by: Youngtaek Yoon <noreply@yoon.mailer.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml