fix: update swap keys for possibly overlapped keys

[jaeseung-bae]

Description

• fix: update swap keys for possibly overlapped keys
  • They should be the same -> (hello, world) != (hell, oworld)

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

• I followed the contributing guidelines and code of conduct.
• I have added a relevant changelog to CHANGELOG.md
• I have added tests to cover my changes.
• I have updated the documentation accordingly.
• I have updated API documentation client/docs/swagger-ui/swagger.yaml

[codecov]

Codecov Report

Attention: Patch coverage is 35.48387% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 69.53%. Comparing base (5e2cd7f) to head (0b9cc3c).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1365      +/-   ##
==========================================
- Coverage   69.53%   69.53%   -0.01%     
==========================================
  Files         672      672              
  Lines       56111    56128      +17     
==========================================
+ Hits        39019    39027       +8     
- Misses      14827    14835       +8     
- Partials     2265     2266       +1     

Files	Coverage Δ
x/fswap/keeper/keys.go	86.66% <84.61%> (-13.34%)	⬇️
x/fswap/types/fswap.go	5.00% <0.00%> (ø)
x/fswap/types/msgs.go	0.00% <0.00%> (ø)
x/fswap/keeper/grpc_query.go	6.97% <0.00%> (-1.60%)	⬇️

... and 1 file with indirect coverage changes

[0Tech]

We should prohibit denoms longer than 255.

[jaeseung-bae]

We should prohibit denoms longer than 255.

Can i have any reason for 255 limit?

[0Tech]

We should prohibit denoms longer than 255.

Can i have any reason for 255 limit?

It's because our newly introduced lengthPrefix() assumes it (converts length to byte).

[jaeseung-bae]

We should prohibit denoms longer than 255.

Can i have any reason for 255 limit?

It's because our newly introduced lengthPrefix() assumes it (converts int to byte).

Thanks for letting me know.

I found regex for denom validation [a-zA-Z][a-zA-Z0-9/-]{2,127}.
function to get key will be called after validation logic, so it's okay without length limit.

[jaeseung-bae]

We should prohibit denoms longer than 255.

Can i have any reason for 255 limit?

It's because our newly introduced lengthPrefix() assumes it (converts int to byte).

Thanks for letting me know.

I found regex for denom validation [a-zA-Z][a-zA-Z0-9/-]{2,127}. function to get key will be called after validation logic, so it's okay without length limit.

I got another case to call without coin validation logic.
I've just made commit to fix it.