feat: support message based proposals #1372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1372 +/- ##
=======================================
Coverage 69.49% 69.50%
=======================================
Files 672 668 -4
Lines 56159 56149 -10
=======================================
- Hits 39028 39026 -2
+ Misses 14864 14856 -8
Partials 2267 2267
|
0Tech
reviewed
May 9, 2024
0Tech
reviewed
May 9, 2024
jaeseung-bae
added
A: improvement
0Tech
reviewed
May 9, 2024
jaeseung-bae
changed the title
jaeseung-bae
changed the title
170210
reviewed
May 9, 2024
170210
reviewed
May 9, 2024
0Tech
approved these changes
May 9, 2024
zemyblue
approved these changes
May 9, 2024
mergify bot
pushed a commit
that referenced
this pull request
May 9, 2024
* feat: change MakeSwapProposal to foundation proposal * chore: refactor MsgMakeSwapProposal -> MsgSetSwap * chore: clean-up * chore: use original proto stringer interface * chore: remove unused proto annotations * chore: allow gov and foundation as authority address * chore: lint fix * chore: remove redundant part * chore: update changelog (cherry picked from commit 97570b2) # Conflicts: # x/fswap/keeper/proposal.go
5 tasks
jaeseung-bae
added a commit
that referenced
this pull request
May 9, 2024
* feat: support message based proposals (#1372) * feat: change MakeSwapProposal to foundation proposal * chore: refactor MsgMakeSwapProposal -> MsgSetSwap * chore: clean-up * chore: use original proto stringer interface * chore: remove unused proto annotations * chore: allow gov and foundation as authority address * chore: lint fix * chore: remove redundant part * chore: update changelog (cherry picked from commit 97570b2) # Conflicts: # x/fswap/keeper/proposal.go * chore: fix conflict --------- Co-authored-by: jaeseung-bae <119839167+jaeseung-bae@users.noreply.github.com> Co-authored-by: jaeseung.bae <jaeseung.bae@linecorp.com> Co-authored-by: zemyblue <zemyblue@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml