chore: refactor to use snake_case in proto #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaeseung-bae
added
A: improvement
jaeseung-bae
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1396 +/- ##
=======================================
Coverage 69.68% 69.68%
=======================================
Files 668 668
Lines 56242 56242
=======================================
Hits 39194 39194
Misses 14775 14775
Partials 2273 2273 |
0Tech
approved these changes
May 24, 2024
170210
approved these changes
May 24, 2024
mergify bot
pushed a commit
that referenced
this pull request
May 24, 2024
* chore: refactor to use snake_case in proto to fix mix-use of camelCase and snake_case * chore: update changelog (cherry picked from commit 59f7256) # Conflicts: # client/docs/swagger-ui/swagger.yaml
5 tasks
jaeseung-bae
added a commit
that referenced
this pull request
May 24, 2024
* chore: refactor to use snake_case in proto to fix mix-use of camelCase and snake_case * chore: update changelog (cherry picked from commit 59f7256) # Conflicts: # client/docs/swagger-ui/swagger.yaml
jaeseung-bae
added a commit
that referenced
this pull request
May 24, 2024
* chore: refactor to use snake_case in proto (#1396) * chore: refactor to use snake_case in proto to fix mix-use of camelCase and snake_case * chore: update changelog (cherry picked from commit 59f7256) # Conflicts: # client/docs/swagger-ui/swagger.yaml * chore: refactor to use snake_case in proto (#1396) * chore: refactor to use snake_case in proto to fix mix-use of camelCase and snake_case * chore: update changelog (cherry picked from commit 59f7256) # Conflicts: # client/docs/swagger-ui/swagger.yaml --------- Co-authored-by: jaeseung-bae <119839167+jaeseung-bae@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml