chore: fix dummy denom coin data for test in fswap (backport #1392) #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* fix: fix dummy denom coin data for test in fswap Signed-off-by: 170210 <j170210@icloud.com> * chore: update CHANGLOG.md Signed-off-by: 170210 <j170210@icloud.com> * fix: fix failed test Signed-off-by: 170210 <j170210@icloud.com> --------- Signed-off-by: 170210 <j170210@icloud.com> (cherry picked from commit 6ca08db)
mergify
bot
requested review from
tkxkd0159,
zemyblue,
0Tech and
jaeseung-bae
as code owners
jaeseung-bae
approved these changes
May 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/v0.49.x #1398 +/- ##
================================================
Coverage 69.04% 69.04%
================================================
Files 671 671
Lines 69299 69299
================================================
+ Hits 47846 47847 +1
+ Misses 19167 19166 -1
Partials 2286 2286 |
0Tech
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
denomMetaDatarequires theDisplayfield to appear in DenomUnits. This PR corrects the error dummy coin data in the test data.https://github.com/Finschia/finschia-sdk/blob/main/x/bank/types/metadata.go#L73-L75
closes: #XXXX
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yamlThis is an automatic backport of pull request #1392 done by [Mergify](https://mergify.com).