-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add bankplus
function to restrict to send coin to inactive smart contract.
#400
Conversation
Codecov Report
@@ Coverage Diff @@
## main #400 +/- ##
=======================================
Coverage ? 53.93%
=======================================
Files ? 685
Lines ? 69999
Branches ? 0
=======================================
Hits ? 37752
Misses ? 29226
Partials ? 3021 |
bankplus
function to restrict to send coin to inactive smart contract.bankplus
function to restrict to send coin to inactive smart contract.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In genernal, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* main: (44 commits) feat: rewrite issue template and move PR template (#410) fix: validate validator addresses in update-validator-auths proposal (#411) feat: add `bankplus` function to restrict to send coin to inactive smart contract. (#400) build(deps): bump actions/setup-go from 2.1.4 to 2.1.5 (#408) ci: fix branch name on ci script (#409) feat: Add CreateValidator access control feature (#406) build(deps): bump github.com/spf13/viper from 1.9.0 to 1.10.1 (#403) build(deps): bump github.com/rs/zerolog from 1.26.0 to 1.26.1 (#402) fix: fix query signing infos command (#407) build(deps): bump github.com/spf13/cobra from 1.1.3 to 1.3.0 (#399) build(deps): github.com/ulikunitz/xz from 0.5.5 to 0.5.10 (#398) build(deps): bump actions/stale from 3 to 4.1.0 (#396) build(deps): bump actions/cache from 2.1.3 to 2.1.7 (#386) feat: Add the `instantiate_permission` in the `CodeInfoResponse` (#395) fix: fix bug where `StoreCodeAndInstantiateContract`, `UpdateContractStatus`, `UpdateContractStatusProposal` API does not work (#393) docs: modify with latest version of swagger REST interface docs. (#392) fix: fix invalid root hash by bumping up tm-db (#388) chore: fix swagger's config path for wasm (#391) build(deps): bump technote-space/get-diff-action from 5.0.1 to 5.0.2 (#379) fix: update allowance inside AllowedMsgAllowance (#383) ...
Description
If the receiver is inactive contract, the transfer is failure.
This function doesn't modify bank module. The
SendCoins
of bank module is wrapped in thebankplus
. But thebankplus
is not other module. It just extends the bank module.Wrapping the
SendCoins
ofbank
moduleIf specific smart contract change to inactive status,
wasm
call theAddBlockedAddr
ofbankplus
. And conversely, if change active,wasm
call theDeleteBlockedAddr
ofbankplus
.All
bank
module should be change tobankplus
when initiate the app.(So,
lbm
should apply this as well.)Add
blockedAddr
for blocked smart contract.The
blockedAddr
of originalbank
module andblockedAddr
ofbankplus
is different.blockedAddr
of originalbank
module is just generated when the app initiate, and manage the list of blocked modules, and it cannot be changed.blockedAddr
ofbankplus
manage inactive smart contracts, and can add/delete when the smart contract's status is changed.closes: #394
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes