Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Revert sig_block_height #434

Merged
merged 8 commits into from
Feb 16, 2022
Merged

feat: Revert sig_block_height #434

merged 8 commits into from
Feb 16, 2022

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented Feb 11, 2022 •
edited
Loading

Description

closes: #433

Revert the signature algorithm using sig_block_height and fix some conflict.

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@zemyblue
Revert "feat: Introduce sig block height for the new replay protection (
f504e28 
Finschia#265)"

This reverts commit c1c71f1.

# Conflicts:
#	CHANGELOG.md
#	baseapp/msg_service_router_test.go
#	client/tx/tx.go
#	codec/amino_codec_test.go
#	docs/core/proto-docs.md
#	proto/lbm/auth/v1/auth.proto
#	server/grpc/server_test.go
#	simapp/genesis_account_test.go
#	simapp/test_helpers.go
#	testutil/testdata/unknonwnproto.pb.go
#	types/errors/errors.go
#	types/grpc/headers.go
#	types/rest/rest_test.go
#	types/tx/tx.pb.go
#	types/tx/types.go
#	x/auth/ante/ante.go
#	x/auth/ante/ante_test.go
#	x/auth/ante/sigverify_test.go
#	x/auth/ante/testutil_test.go
#	x/auth/client/cli/cli_test.go
#	x/auth/keeper/keeper.go
#	x/auth/legacy/legacytx/amino_signing_test.go
#	x/auth/signing/handler_map_test.go
#	x/auth/signing/verify_test.go
#	x/auth/simulation/decoder.go
#	x/auth/simulation/genesis.go
#	x/auth/tx/builder.go
#	x/auth/tx/direct_test.go
#	x/auth/tx/legacy_amino_json_test.go
#	x/auth/types/account.go
#	x/auth/types/account_retriever.go
#	x/auth/types/account_test.go
#	x/auth/types/auth.pb.go
#	x/auth/types/params.go
#	x/auth/vesting/types/vesting_account.go
#	x/auth/vesting/types/vesting_account_test.go
#	x/evidence/keeper/keeper_test.go
#	x/ibc/testing/chain.go
#	x/wasm/keeper/keeper_test.go
#	x/wasm/keeper/submsg_test.go
@zemyblue zemyblue marked this pull request as draft February 11, 2022 06:43
@zemyblue
Revert "feat: Introduce sig block height for the new replay protection (
684a30b 
Finschia#265)"

This reverts commit c1c71f1.

# Conflicts:
#	CHANGELOG.md
#	baseapp/msg_service_router_test.go
#	client/tx/tx.go
#	codec/amino_codec_test.go
#	docs/core/proto-docs.md
#	proto/lbm/auth/v1/auth.proto
#	server/grpc/server_test.go
#	simapp/genesis_account_test.go
#	simapp/test_helpers.go
#	testutil/testdata/unknonwnproto.pb.go
#	types/errors/errors.go
#	types/grpc/headers.go
#	types/rest/rest_test.go
#	types/tx/tx.pb.go
#	types/tx/types.go
#	x/auth/ante/ante.go
#	x/auth/ante/ante_test.go
#	x/auth/ante/sigverify_test.go
#	x/auth/ante/testutil_test.go
#	x/auth/client/cli/cli_test.go
#	x/auth/keeper/keeper.go
#	x/auth/legacy/legacytx/amino_signing_test.go
#	x/auth/signing/handler_map_test.go
#	x/auth/signing/verify_test.go
#	x/auth/simulation/decoder.go
#	x/auth/simulation/genesis.go
#	x/auth/tx/builder.go
#	x/auth/tx/direct_test.go
#	x/auth/tx/legacy_amino_json_test.go
#	x/auth/types/account.go
#	x/auth/types/account_retriever.go
#	x/auth/types/account_test.go
#	x/auth/types/auth.pb.go
#	x/auth/types/params.go
#	x/auth/vesting/types/vesting_account.go
#	x/auth/vesting/types/vesting_account_test.go
#	x/evidence/keeper/keeper_test.go
#	x/ibc/testing/chain.go
#	x/wasm/keeper/keeper_test.go
#	x/wasm/keeper/submsg_test.go
@codecov
Copy link

codecov bot commented Feb 11, 2022 •
edited
Loading

Codecov Report

Merging #434 (3bbaa2f) into main (9d931a6) will increase coverage by 0.04%.
The diff coverage is 79.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #434      +/-   ##
==========================================
+ Coverage   54.26%   54.31%   +0.04%     
==========================================
  Files         699      699              
  Lines       71498    71476      -22     
==========================================
+ Hits        38799    38820      +21     
+ Misses      29630    29596      -34     
+ Partials     3069     3060       -9
Impacted Files Coverage Δ
client/flags/flags.go 18.75% <0.00%> (ø)
client/test_helpers.go 0.00% <0.00%> (ø)
client/tx/legacy.go 0.00% <ø> (ø)
server/mock/tx.go 63.15% <ø> (+3.15%) ⬆️
simapp/test_helpers.go 6.89% <0.00%> (ø)
types/errors/errors.go 83.83% <ø> (ø)
types/tx_msg.go 0.00% <ø> (ø)
x/auth/ante/basic.go 79.09% <ø> (-3.22%) ⬇️
x/auth/client/tx.go 36.66% <0.00%> (ø)
x/auth/genesis.go 30.43% <0.00%> (-1.39%) ⬇️
... and 49 more

@zemyblue
Copy link
Member Author

zemyblue commented Feb 11, 2022 •
edited
Loading

feegrant module has difference with latest version of 0.43.x and over of cosmos-sdk. So we should re-check the all codes of feegrant module. Since this difference I think there will be many conflict when dump up.

And please check the following code of ante handler. I removed it because this checker occurs many errors.

https://github.com/line/lbm-sdk/pull/434/files#diff-e7b77179f4b011191f102b6d407a8295311bf2a6a7f141c1d4745d8f0b21db8fR29

@zemyblue zemyblue marked this pull request as ready for review February 11, 2022 16:45
@zemyblue zemyblue self-assigned this Feb 11, 2022
brew0722
brew0722 reviewed Feb 15, 2022
View reviewed changes
x/auth/ante/sigverify.go Outdated Show resolved Hide resolved
dudong2
dudong2 reviewed Feb 15, 2022
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
x/auth/tx/direct.go Outdated Show resolved Hide resolved
x/auth/ante/sigverify.go Outdated Show resolved Hide resolved
@zemyblue @dudong2
Update x/auth/tx/direct.go
3bbaa2f 
fix: wrong comment.

Co-authored-by: Sujong Lee <leesj9476@naver.com>
@zemyblue zemyblue merged commit fcd999c into Finschia:main Feb 16, 2022
@zemyblue zemyblue mentioned this pull request Mar 4, 2022
Merged
5 tasks
zemyblue added a commit to zemyblue/finschia-sdk that referenced this pull request Mar 4, 2022
@zemyblue
Merge branch 'main' into simapp_with_wasm
c7fa27e 
* main:
  fix: `make proto-format` bug in the Makefile (Finschia#438)
  feat: Revert sig_block_height (Finschia#434)
  build(deps): bump actions/setup-go from 2.1.5 to 2.2.0 (Finschia#432)
  build(deps): bump github.com/prometheus/client_golang (Finschia#424)
  chore: remove `x/wasm/linkwasmd` (Finschia#436)
  build(deps): bump github.com/VictoriaMetrics/fastcache (Finschia#429)
  fix: apply fix from release branch (Finschia#428)

# Conflicts:
#	CHANGELOG.md
@zemyblue zemyblue deleted the issue_433 branch December 23, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0Tech 0Tech 0Tech approved these changes

@dudong2 dudong2 dudong2 approved these changes

@brew0722 brew0722 brew0722 approved these changes

@iproudhon iproudhon Awaiting requested review from iproudhon

Assignees

@zemyblue zemyblue

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rollback new signing mechanism
4 participants
@zemyblue @0Tech @dudong2 @brew0722