Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make proto-format bug in the Makefile #438

Merged
merged 5 commits into from
Feb 16, 2022

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented Feb 15, 2022

Description

  • fix: make proto-format bug in the Makefile
  • chore: change make proto-lint to use clang-format lint
  • ci: change proto-lint action to use clang-format lint

make proto-format change the format of protobuf files as clang-format style but the proto-lint check golang-ci lint style. Checking and formatting are different. So need to match it.

closes: #XXXX

Motivation and context

make proto-format is not working. I think the docker image file seems to be disappeared. The cosmos-sdk also doesn't work.
The right docker for formating the protobuf file is tendermintdev/docker-build-proto

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes. (no need)
  • I have updated the documentation accordingly. (no need)
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml (no need)

Copy link
Contributor

@dudong2 dudong2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zemyblue zemyblue self-assigned this Feb 15, 2022
@zemyblue zemyblue added the A: bug Something isn't working label Feb 15, 2022
Copy link
Contributor

@iproudhon iproudhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zemyblue zemyblue merged commit 7947e4c into Finschia:main Feb 16, 2022
@zemyblue zemyblue mentioned this pull request Mar 4, 2022
5 tasks
zemyblue added a commit to zemyblue/finschia-sdk that referenced this pull request Mar 4, 2022
* main:
  fix: `make proto-format` bug in the Makefile (Finschia#438)
  feat: Revert sig_block_height (Finschia#434)
  build(deps): bump actions/setup-go from 2.1.5 to 2.2.0 (Finschia#432)
  build(deps): bump github.com/prometheus/client_golang (Finschia#424)
  chore: remove `x/wasm/linkwasmd` (Finschia#436)
  build(deps): bump github.com/VictoriaMetrics/fastcache (Finschia#429)
  fix: apply fix from release branch (Finschia#428)

# Conflicts:
#	CHANGELOG.md
@zemyblue zemyblue deleted the fix_proto_format branch December 23, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants