Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Merge wasmd 0.19.0 #444

Merged
merged 92 commits into from
Mar 3, 2022
Merged

build: Merge wasmd 0.19.0 #444

merged 92 commits into from
Mar 3, 2022

Conversation

loloicci
Copy link
Member

Description

Merging CosmWasm/wasmd/x/wasm 's version 0.19.0

Motivation and context

We will upgrade cosmwasm and wasmvm to version 0.16.x. And, this upgrade needs to use them.

How has this been tested?

Unit tests in x/wasm.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

alpe and others added 30 commits January 5, 2022 17:31
* Store contract response in event

* Review feedback
* Add cli alias

* Review feedback
* Charge gas for custom event attributes

* Introduce gas register for gas costs

* Review feedback

* Tests and minor updates

* Godoc
(cherry-pick: tests are not done before upgrading wasmvm v0.16.x)
@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #444 (1ff37cf) into main (4bb7b33) will increase coverage by 0.18%.
The diff coverage is 73.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #444      +/-   ##
==========================================
+ Coverage   55.54%   55.73%   +0.18%     
==========================================
  Files         716      719       +3     
  Lines       73837    73921      +84     
==========================================
+ Hits        41012    41198     +186     
+ Misses      29714    29611     -103     
- Partials     3111     3112       +1     
Impacted Files Coverage Δ
baseapp/options.go 65.51% <ø> (ø)
client/grpc/tmservice/service.go 59.45% <ø> (ø)
server/config/config.go 42.71% <ø> (ø)
simapp/app.go 84.38% <ø> (ø)
store/cache/cache.go 81.92% <ø> (ø)
store/iavl/cache.go 96.36% <ø> (ø)
x/auth/client/cli/tx.go 0.00% <ø> (ø)
x/consortium/client/testutil/query.go 100.00% <ø> (ø)
x/feegrant/client/testutil/suite.go 99.62% <ø> (ø)
x/feegrant/keeper/grpc_query.go 78.94% <ø> (ø)
... and 47 more

@loloicci loloicci marked this pull request as ready for review February 24, 2022 07:27
@@ -115,7 +117,7 @@ func TestSDKMessageHandlerDispatch(t *testing.T) {
}{
"all good": {
srcRoute: sdk.NewRoute(types.RouterKey, capturingRouteFn),
srcEncoder: func(sender sdk.AccAddress, msg json.RawMessage, customEncodeRouter types.Router) ([]sdk.Msg, error) {
Copy link
Contributor

@brew0722 brew0722 Mar 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember CustomEncoder was added for Token/collection module encoding.
When the Token/Collection module porting is complete, we need to re-enable it.

Is there a reason to delete the custom encoder again in this migration?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct. But this patch contains various changes around these functions, so I chose to delete it temporarily and re-enable it after porting the Token/Collection module.

Copy link
Contributor

@brew0722 brew0722 Mar 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. In my opinion, It's kind of a rollback, so I want it to remain as is as possible.
However since the time remaining until release is too tight, please make it a other issue. and please don't miss out write the changelog.

go.mod Outdated Show resolved Hide resolved
proto/lbm/wasm/v1/proposal.proto Outdated Show resolved Hide resolved
@@ -0,0 +1,1116 @@
<!-- This file is auto-generated. Please do not modify it yourself. -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file appears to be a duplicate of the following, is that necessary?
docs/core/proto-docs.md

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice found

@brew0722
Copy link
Contributor

brew0722 commented Mar 3, 2022

store-instantiate still has --source and --builder options. we need remove this.

user@AL01696733 lbm % lbm tx wasm store-instantiate
Error: accepts 2 arg(s), received 0
Usage:
lbm tx wasm store-instantiate [wasm file] [json_encoded_init_args] --source [source] --builder [builder] --label [text] --admin [address,optional] --amount [coins,optional] [flags]

@loloicci
Copy link
Member Author

loloicci commented Mar 3, 2022

@brew0722

store-instantiate still has --source and --builder options. we need remove this.

Thanks. It is in only help message and does not work now. I removed them from help messages.

@brew0722
Copy link
Contributor

brew0722 commented Mar 3, 2022

In general, LGTM. please add to the Unreleased section in the changelog.

@loloicci loloicci changed the title build: Merging wasmd 0.19.0 build: Merge wasmd 0.19.0 Mar 3, 2022
@loloicci loloicci merged commit 41c3954 into Finschia:main Mar 3, 2022
@zemyblue zemyblue mentioned this pull request Mar 4, 2022
5 tasks
@loloicci loloicci deleted the versionup-19 branch August 9, 2022 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants