Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove contract activation control by actor #470

Merged

Conversation

brew0722
Copy link
Contributor

@brew0722 brew0722 commented Mar 21, 2022

Description

closes: #467

Motivation and context

  • remove contract access control by actor
  • remove contract status access config

How has this been tested?

  • re-add inactive contract tests using gov proposal

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@brew0722 brew0722 self-assigned this Mar 21, 2022
@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #470 (e6abf41) into main (d2ba9c1) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #470      +/-   ##
==========================================
+ Coverage   55.73%   55.78%   +0.05%     
==========================================
  Files         719      719              
  Lines       73921    73829      -92     
==========================================
- Hits        41201    41187      -14     
+ Misses      29609    29535      -74     
+ Partials     3111     3107       -4     
Impacted Files Coverage Δ
x/wasm/client/cli/new_tx.go 0.00% <ø> (ø)
x/wasm/client/cli/tx.go 14.54% <ø> (+0.05%) ⬆️
x/wasm/handler.go 73.33% <ø> (+3.12%) ⬆️
x/wasm/keeper/msg_server.go 0.00% <ø> (ø)
x/wasm/types/codec.go 100.00% <ø> (ø)
x/wasm/types/params.go 65.82% <ø> (+10.60%) ⬆️
x/wasm/types/tx.go 46.79% <ø> (-1.89%) ⬇️
x/wasm/keeper/authz_policy.go 100.00% <100.00%> (ø)
x/wasm/keeper/keeper.go 84.85% <100.00%> (-0.81%) ⬇️
snapshots/store.go 71.66% <0.00%> (-1.25%) ⬇️
... and 3 more

@@ -38,6 +38,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
## [Unreleased](https://github.com/line/lbm-sdk/compare/v0.45.0-rc0...HEAD)

### Features
* (x/wasm) [\#470](https://github.com/line/lbm-sdk/pull/470) remove contract activation control by actor
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modifications due to policy changes.
So, it was judged that it was not a bugfix, and it was judged as a feature.

x/wasm/keeper/keeper_test.go Outdated Show resolved Hide resolved
x/wasm/keeper/keeper_test.go Outdated Show resolved Hide resolved
x/wasm/keeper/keeper_test.go Outdated Show resolved Hide resolved
x/wasm/keeper/keeper_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@shiki-tak shiki-tak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brew0722 brew0722 merged commit 7075790 into Finschia:main Mar 23, 2022
@brew0722 brew0722 deleted the remove-contract-activation-control-by-actor branch March 23, 2022 00:49
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change logics of the contract blacklist function
3 participants