ci: disable swagger check temporarily #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #471 +/- ##
==========================================
- Coverage 55.73% 55.72% -0.01%
==========================================
Files 719 719
Lines 73921 73921
==========================================
- Hits 41201 41195 -6
- Misses 29609 29613 +4
- Partials 3111 3113 +2
|
This reverts commit 3a37968.
dudong2
approved these changes
Mar 22, 2022
zemyblue
reviewed
Mar 22, 2022
CHANGELOG.md
Outdated
| @@ -50,5 +50,6 @@ Ref: https://keepachangelog.com/en/1.0.0/ | |||
|
|
|||
| * (ci) [\#457](https://github.com/line/lbm-sdk/pull/457) add swagger check | |||
| * (ci) [\#469](https://github.com/line/lbm-sdk/pull/469) publish docker image on tag push | |||
| * (ci) [\#471](https://github.com/line/lbm-sdk/pull/471) disable swagger check temporarily | |||
There was a problem hiding this comment.
I think this changes is a fix for #457.
Then, how about adding it to line 51 like below?
* (ci) #457, #471 add swagger check
There was a problem hiding this comment.
I agree on squashing the entries as you suggested. But the check would not working after this PR. Let me change the title.
There was a problem hiding this comment.
Is it OK to have a title different from it's PR's? Or I cannot change the title because it affects the previous PR (#457).
brew0722
pushed a commit
to brew0722/lbm-sdk
that referenced
this pull request
Mar 22, 2022
* main: ci: disable swagger check temporarily (Finschia#471)
96 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checking generated swagger files (#457) is not working as expected, so I remove the logic and insert an action to print the log for the analysis.
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml[no need]