-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix naming collision in x/token enums #589
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #589 +/- ##
==========================================
- Coverage 57.55% 57.55% -0.01%
==========================================
Files 796 797 +1
Lines 87575 87593 +18
==========================================
+ Hits 50407 50416 +9
- Misses 34027 34035 +8
- Partials 3141 3142 +1
|
zemyblue
reviewed
Jul 14, 2022
dudong2
approved these changes
Jul 14, 2022
dudong2
approved these changes
Jul 14, 2022
zemyblue
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The patch changes the following enum in the protos:
Motivation and context
Some of the names in the enums were not unique, which caused compile errors on java.
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml