Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix naming collision in x/token enums #589

Merged
merged 6 commits into from
Jul 18, 2022
Merged

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Jul 11, 2022

Description

The patch changes the following enum in the protos:

  1. Permission
  2. EventType
  3. AttributeKey

Motivation and context

Some of the names in the enums were not unique, which caused compile errors on java.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech added the A: bug Something isn't working label Jul 11, 2022
@0Tech 0Tech self-assigned this Jul 11, 2022
@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #589 (6c0d3b3) into main (f46f02b) will decrease coverage by 0.00%.
The diff coverage is 59.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #589      +/-   ##
==========================================
- Coverage   57.55%   57.55%   -0.01%     
==========================================
  Files         796      797       +1     
  Lines       87575    87593      +18     
==========================================
+ Hits        50407    50416       +9     
- Misses      34027    34035       +8     
- Partials     3141     3142       +1     
Impacted Files Coverage Δ
x/token/event.go 3.59% <9.52%> (+3.59%) ⬆️
x/token/client/testutil/query.go 100.00% <100.00%> (ø)
x/token/client/testutil/suite.go 100.00% <100.00%> (ø)
x/token/client/testutil/tx.go 100.00% <100.00%> (ø)
x/token/genesis.go 100.00% <100.00%> (ø)
x/token/keeper/alias.go 85.71% <100.00%> (ø)
x/token/keeper/genesis.go 100.00% <100.00%> (ø)
x/token/keeper/grpc_query.go 94.05% <100.00%> (-0.03%) ⬇️
x/token/keeper/msg_server.go 92.64% <100.00%> (ø)
x/token/keeper/supply.go 90.76% <100.00%> (ø)
... and 4 more

@0Tech 0Tech requested review from dudong2 and zemyblue July 13, 2022 03:09
@0Tech 0Tech marked this pull request as ready for review July 13, 2022 03:10
@0Tech 0Tech merged commit c6f7293 into Finschia:main Jul 18, 2022
@0Tech 0Tech deleted the token branch July 18, 2022 06:27
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Something isn't working C:x/token
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants