refactor: remove SetBalance and SetSupply #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #629 +/- ##
==========================================
+ Coverage 60.18% 60.26% +0.07%
==========================================
Files 817 817
Lines 94996 94967 -29
==========================================
+ Hits 57178 57228 +50
+ Misses 34359 34260 -99
- Partials 3459 3479 +20
|
dudong2
changed the title
dudong2
deleted the
dudong2/refactor/remove-unsafe-balance-changing-methods
branch
zemyblue
added a commit
that referenced
this pull request
Sep 5, 2022
* main: fix: wasm module's FIXME in the snapshotter.go file (#649) chore(deps): Bump actions/setup-go from 3.2.1 to 3.3.0 (#650) chore(deps): Bump actions/cache from 3.0.7 to 3.0.8 (#648) fix: remove legacy codes of wasm (#640) chore(deps): Bump github.com/mattn/go-isatty from 0.0.14 to 0.0.16 (#643) chore(deps): Bump actions/cache from 3.0.6 to 3.0.7 (#642) chore: change some minor things that haven't been fixed in #549 (#635) refactor: rename x/collection events (#639) feat: add additional fields into x/collection events (#638) refactor: rename x/token events (#637) feat: add creator into x/token EventIssue (#636) chore(deps): Bump github.com/coinbase/rosetta-sdk-go (#641) chore: change `Keeper.space` type to be same with cosmos-sdk refactor: remove SetBalance and SetSupply (#629) refactor: revert changes in x/slashing proto (#627) chore(deps): Bump actions/cache from 3.0.5 to 3.0.6 (#631) chore(deps): Bump github.com/prometheus/client_golang (#632) chore(deps): Bump actions/setup-go from 2.1.4 to 3.2.1 (#624) feat: add Query/TokenClassTypeName (#622) feat: add additional information into EventXXXChanged (#621) Signed-off-by: zemyblue <zemyblue@gmail.com> # Conflicts: # CHANGELOG.md # client/docs/statik/statik.go # simapp/app.go # x/wasm/types/events.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove unsafe balance changing methods from bank keeper such as SetBalance and SetSupply.
closes: #628
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml