Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add additional information into EventXXXChanged #621

Merged
merged 4 commits into from
Aug 6, 2022

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Aug 2, 2022

Description

This patch will additional information into lbm.collection.v1.EventOwnerChanged and lbm.collection.v1.EventRootChanged.

  • lbm.collection.v1.EventOwnerChanged:
    • from: address of the previous owner before the change.
    • to: address of the new owner.
  • lbm.collection.v1.EventRootChanged:
    • from: id of the previous root before the change.
    • to: id of the new root.

Motivation and context

The request by our client.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech added A: improvement Changes in existing functionality C:x/collection labels Aug 2, 2022
@0Tech 0Tech self-assigned this Aug 2, 2022
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #621 (27eb67c) into main (9ba6ea3) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #621      +/-   ##
==========================================
+ Coverage   60.19%   60.22%   +0.03%     
==========================================
  Files         817      817              
  Lines       94971    94978       +7     
==========================================
+ Hits        57169    57204      +35     
+ Misses      34329    34296      -33     
- Partials     3473     3478       +5     
Impacted Files Coverage Δ
x/collection/keeper/nft.go 89.42% <100.00%> (+0.23%) ⬆️
x/collection/keeper/send.go 91.26% <100.00%> (+0.17%) ⬆️
x/token/validation.go 78.18% <0.00%> (-12.73%) ⬇️
x/wasm/keeper/keeper.go 85.74% <0.00%> (-0.36%) ⬇️
x/token/msgs.go 36.54% <0.00%> (ø)
crypto/keys/internal/ecdsa/privkey.go 84.21% <0.00%> (+1.75%) ⬆️
x/collection/msgs.go 41.85% <0.00%> (+2.96%) ⬆️
x/foundation/foundation.go 74.72% <0.00%> (+3.61%) ⬆️
x/foundation/msgs.go 42.78% <0.00%> (+4.32%) ⬆️
x/foundation/authz.go 100.00% <0.00%> (+20.00%) ⬆️

@0Tech 0Tech requested review from dudong2 and zemyblue August 2, 2022 07:04
@0Tech 0Tech marked this pull request as ready for review August 2, 2022 07:04
@0Tech 0Tech merged commit b9242f3 into Finschia:main Aug 6, 2022
@0Tech 0Tech deleted the collection_event branch August 6, 2022 02:02
zemyblue added a commit that referenced this pull request Sep 5, 2022
* main:
  fix: wasm module's FIXME in the snapshotter.go file (#649)
  chore(deps): Bump actions/setup-go from 3.2.1 to 3.3.0 (#650)
  chore(deps): Bump actions/cache from 3.0.7 to 3.0.8 (#648)
  fix: remove legacy codes of wasm (#640)
  chore(deps): Bump github.com/mattn/go-isatty from 0.0.14 to 0.0.16 (#643)
  chore(deps): Bump actions/cache from 3.0.6 to 3.0.7 (#642)
  chore: change some minor things that haven't been fixed in #549 (#635)
  refactor: rename x/collection events (#639)
  feat: add additional fields into x/collection events (#638)
  refactor: rename x/token events (#637)
  feat: add creator into x/token EventIssue (#636)
  chore(deps): Bump github.com/coinbase/rosetta-sdk-go (#641)
  chore: change `Keeper.space` type to be same with cosmos-sdk
  refactor: remove SetBalance and SetSupply (#629)
  refactor: revert changes in x/slashing proto (#627)
  chore(deps): Bump actions/cache from 3.0.5 to 3.0.6 (#631)
  chore(deps): Bump github.com/prometheus/client_golang (#632)
  chore(deps): Bump actions/setup-go from 2.1.4 to 3.2.1 (#624)
  feat: add Query/TokenClassTypeName (#622)
  feat: add additional information into EventXXXChanged (#621)

Signed-off-by: zemyblue <zemyblue@gmail.com>

# Conflicts:
#	CHANGELOG.md
#	client/docs/statik/statik.go
#	simapp/app.go
#	x/wasm/types/events.go
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: improvement Changes in existing functionality C:x/collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants