feat: introduce censorship into x/foundation #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0Tech
added
A: improvement
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #912 +/- ##
==========================================
+ Coverage 62.34% 62.36% +0.01%
==========================================
Files 653 655 +2
Lines 79485 79759 +274
==========================================
+ Hits 49558 49741 +183
- Misses 27248 27334 +86
- Partials 2679 2684 +5
|
0Tech
commented
Feb 23, 2023
0Tech
requested review from
jaeseung-bae,
zemyblue,
dudong2,
loin3 and
tkxkd0159
0Tech
commented
Feb 23, 2023
dudong2
previously approved these changes
Mar 10, 2023
jaeseung-bae
approved these changes
Mar 13, 2023
zemyblue
reviewed
Mar 14, 2023
Please refer to the corresponding item in the description of this PR:
You can change the authority into |
zemyblue
reviewed
Mar 14, 2023
loin3
approved these changes
Mar 14, 2023
zemyblue
reviewed
Mar 14, 2023
Comment on lines
+171
to
+177
| authorityAddrs := map[foundation.CensorshipAuthority]string{ | ||
| foundation.CensorshipAuthorityGovernance: authtypes.NewModuleAddress(govtypes.ModuleName).String(), | ||
| foundation.CensorshipAuthorityFoundation: k.authority, | ||
| } | ||
| if expected := authorityAddrs[censorship.Authority]; authority != expected { | ||
| return sdkerrors.ErrUnauthorized.Wrapf("invalid authority; expected %s, got %s", expected, authority) | ||
| } |
There was a problem hiding this comment.
I think it's good to use if-else, how about this?
zemyblue
pushed a commit
to zemyblue/finschia-sdk
that referenced
this pull request
Mar 17, 2023
* Add censorship into proto * Implement censorship * Add FoundationExecProposal to proto * Implement FoundationExecProposal * Update documentation * Update CHANGELOG.md * Rename files * Lint * Add amino test on MsgUpdateCensorship * Add pagination on cli * Update x/foundation/README.md * Update proposal cli description * Chore * Apply feedbacks (cherry picked from commit d9428ec)
5 tasks
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch would:
Censorship, which has its target message type url and authority.CENSORSHIP_AUTHORITY_GOVERNANCECENSORSHIP_AUTHORITY_FOUNDATION/lbm.foundation.v1.MsgUpdateCensorship/lbm.foundation.v1.MsgGrant/lbm.foundation.v1.MsgRevoke/lbm.foundation.v1.MsgUpdateCensorship, which updates censorship information.CENSORSHIP_AUTHORITY_UNSPECIFIED.FoundationExecProposalwhich allows x/gov's authority to trigger x/foundation's messages./lbm.foundation.v1.MsgUpdateCensorship/lbm.foundation.v1.MsgGrant/lbm.foundation.v1.MsgRevokecloses: #910
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml