Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add "uri" for MsgModify and deprecate the old ones #900

Merged
merged 11 commits into from
Feb 28, 2023
Merged

feat: add "uri" for MsgModify and deprecate the old ones #900

merged 11 commits into from
Feb 28, 2023

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Feb 14, 2023 •
edited
Loading

Description

closes: #899

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech added A: improvement Changes in existing functionality C:x/collection C:x/token labels Feb 14, 2023
@0Tech 0Tech self-assigned this Feb 14, 2023
@codecov
Copy link

codecov bot commented Feb 14, 2023 •
edited
Loading

Codecov Report

Merging #900 (ee6f64d) into main (302cb11) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #900      +/-   ##
==========================================
+ Coverage   62.33%   62.34%   +0.01%     
==========================================
  Files         653      653              
  Lines       79467    79485      +18     
==========================================
+ Hits        49536    49558      +22     
+ Misses      27252    27248       -4     
  Partials     2679     2679
Impacted Files Coverage Δ
x/collection/genesis.go 93.20% <100.00%> (ø)
x/collection/keeper/msg_server.go 90.15% <100.00%> (+0.02%) ⬆️
x/collection/keeper/supply.go 88.26% <100.00%> (ø)
x/collection/msgs.go 96.81% <100.00%> (+0.08%) ⬆️
x/token/genesis.go 100.00% <100.00%> (ø)
x/token/keeper/msg_server.go 94.73% <100.00%> (+0.05%) ⬆️
x/token/keeper/supply.go 89.13% <100.00%> (ø)
x/token/msgs.go 98.92% <100.00%> (+0.03%) ⬆️
x/token/validation.go 100.00% <100.00%> (ø)
simapp/simd/cmd/root.go 87.92% <0.00%> (-1.12%) ⬇️
... and 2 more

@0Tech 0Tech marked this pull request as ready for review February 14, 2023 04:37
0Tech
0Tech commented Feb 14, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@0Tech

This comment was marked as resolved.

Sign in to view
zemyblue
zemyblue reviewed Feb 14, 2023
View reviewed changes
go.mod Show resolved Hide resolved
@zemyblue
Copy link
Member

Please check if no problem with related team, @0Tech .

@0Tech
Copy link
Collaborator Author

0Tech commented Feb 14, 2023

Please check if no problem with related team, @0Tech .

Thank you.

For other reviewers: this PR is now under review by our clients.

@0Tech 0Tech marked this pull request as draft February 20, 2023 12:43
@0Tech 0Tech marked this pull request as ready for review February 21, 2023 00:06
@0Tech 0Tech requested a review from zemyblue February 21, 2023 07:23
@0Tech 0Tech requested a review from dudong2 February 21, 2023 07:23
@0Tech
Copy link
Collaborator Author

0Tech commented Feb 21, 2023

Please check if no problem with related team, @0Tech .

Thank you.

For other reviewers: this PR is now under review by our clients.

Done.

@0Tech 0Tech requested a review from zemyblue February 23, 2023 01:48
jaeseung-bae
jaeseung-bae approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@jaeseung-bae jaeseung-bae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loin3 loin3 self-requested a review February 27, 2023 02:59
@0Tech 0Tech merged commit 81fec6d into Finschia:main Feb 28, 2023
@0Tech 0Tech deleted the uri branch February 28, 2023 09:10
zemyblue pushed a commit to zemyblue/finschia-sdk that referenced this pull request Mar 17, 2023
@0Tech @zemyblue
feat: add "uri" for MsgModify and deprecate the old ones (Finschia#900)
884dc49 
* Add uri to x/token

* Add tests

* Add uri to x/collection

* Add tests

* Update CHANGELOG.md

* Update CHANGELOG.md

* Emit both old and new change

* Add tests

* Remove xxx_uri from events

* Revert irrelevant changes

* Lint

(cherry picked from commit 81fec6d)
@zemyblue zemyblue mentioned this pull request Mar 17, 2023
Merged
5 tasks
zemyblue added a commit that referenced this pull request Mar 22, 2023
@zemyblue
Merge pull request #937 from zemyblue/backporting_main
8bb999d 
Backport main changes (#900, #911, #912, #922, #923, #934, #939, #933, #934, #938)
This was referenced Mar 22, 2023
Closed
Merged
@zemyblue zemyblue mentioned this pull request Apr 24, 2023
Merged
@0Tech 0Tech mentioned this pull request Aug 1, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeseung-bae jaeseung-bae jaeseung-bae approved these changes

@loin3 loin3 loin3 approved these changes

@zemyblue zemyblue zemyblue approved these changes

@tkxkd0159 tkxkd0159 Awaiting requested review from tkxkd0159 tkxkd0159 is a code owner

@dudong2 dudong2 Awaiting requested review from dudong2

Assignees

@0Tech 0Tech

Labels
A: improvement Changes in existing functionality C:x/collection C:x/token
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MsgModify in x/token,collection should also accept "uri"
5 participants
@0Tech @zemyblue @dudong2 @loin3 @jaeseung-bae