-
Notifications
You must be signed in to change notification settings - Fork 28
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: grpc_client_test and fix grpc_client
StopForError()
hang bug (#…
…155)
- Loading branch information
1 parent
afe46e5
commit 5ffdd69
Showing
1 changed file
with
93 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,93 @@ | ||
package abcicli_test | ||
|
||
import ( | ||
"errors" | ||
"fmt" | ||
"testing" | ||
"time" | ||
|
||
"github.com/stretchr/testify/assert" | ||
"github.com/stretchr/testify/require" | ||
|
||
abcicli "github.com/tendermint/tendermint/abci/client" | ||
"github.com/tendermint/tendermint/abci/server" | ||
"github.com/tendermint/tendermint/abci/types" | ||
tmrand "github.com/tendermint/tendermint/libs/rand" | ||
"github.com/tendermint/tendermint/libs/service" | ||
) | ||
|
||
type errorStopper interface { | ||
StopForError(error) | ||
} | ||
|
||
func TestSocketClientStopForErrorDeadlock(t *testing.T) { | ||
c := abcicli.NewGRPCClient(":80", false).(errorStopper) | ||
err := errors.New("foo-tendermint") | ||
|
||
// See Issue https://github.com/tendermint/abci/issues/114 | ||
doneChan := make(chan bool) | ||
go func() { | ||
defer close(doneChan) | ||
c.StopForError(err) | ||
c.StopForError(err) | ||
}() | ||
|
||
select { | ||
case <-doneChan: | ||
case <-time.After(time.Second * 4): | ||
t.Fatalf("Test took too long, potential deadlock still exists") | ||
} | ||
} | ||
|
||
func TestProperSyncCalls(t *testing.T) { | ||
app := slowApp{} | ||
|
||
s, c := setupClientServer(t, app) | ||
defer s.Stop() | ||
defer c.Stop() | ||
|
||
resp := make(chan error, 1) | ||
go func() { | ||
// This is BeginBlockSync unrolled.... | ||
reqres := c.BeginBlockAsync(types.RequestBeginBlock{}) | ||
c.FlushSync() | ||
res := reqres.Response.GetBeginBlock() | ||
require.NotNil(t, res) | ||
resp <- c.Error() | ||
}() | ||
|
||
select { | ||
case <-time.After(time.Second): | ||
require.Fail(t, "No response arrived") | ||
case err, ok := <-resp: | ||
require.True(t, ok, "Must not close channel") | ||
assert.NoError(t, err, "This should return success") | ||
} | ||
} | ||
|
||
func setupClientServer(t *testing.T, app types.Application) ( | ||
service.Service, abcicli.Client) { | ||
// some port between 20k and 30k | ||
port := 20000 + tmrand.Int32()%10000 | ||
addr := fmt.Sprintf("localhost:%d", port) | ||
|
||
s, err := server.NewServer(addr, "grpc", app) | ||
require.NoError(t, err) | ||
err = s.Start() | ||
require.NoError(t, err) | ||
|
||
c := abcicli.NewGRPCClient(addr, true) | ||
err = c.Start() | ||
require.NoError(t, err) | ||
|
||
return s, c | ||
} | ||
|
||
type slowApp struct { | ||
types.BaseApplication | ||
} | ||
|
||
func (slowApp) BeginBlock(req types.RequestBeginBlock) types.ResponseBeginBlock { | ||
time.Sleep(200 * time.Millisecond) | ||
return types.ResponseBeginBlock{} | ||
} |