Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add dynamic callstack for prevent the re-entrancy attack #62

Merged
merged 5 commits into from
Apr 28, 2022
Merged

feat: add dynamic callstack for prevent the re-entrancy attack #62

merged 5 commits into from
Apr 28, 2022

Conversation

brew0722
Copy link
Contributor

@brew0722 brew0722 commented Apr 8, 2022 •
edited
Loading

Description

Closes Finschia/cosmwasm#178

ditto. please read more detail in the above.

Types of changes

  • Bug fix (changes which fixes an issue)
  • New feature (changes which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ETC (build, ci, docs, perf, refactor, style, test)

Checklist

@brew0722 brew0722 added enhancement New feature or request dynamic_link relate the dynamic link call feature labels Apr 8, 2022
@brew0722 brew0722 self-assigned this Apr 8, 2022
@brew0722 brew0722 changed the base branch from main to dynamic_link April 8, 2022 05:53
@brew0722 brew0722 mentioned this pull request Apr 8, 2022
Merged
8 tasks
@brew0722
Copy link
Contributor Author

rebased to squash merged PR(#61).

brew0722
brew0722 commented Apr 21, 2022
View reviewed changes
src/api.rs Outdated Show resolved Hide resolved
shiki-tak
shiki-tak approved these changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@shiki-tak shiki-tak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brew0722 brew0722 mentioned this pull request Apr 27, 2022
Merged
8 tasks
@brew0722 brew0722 merged commit ea65d9f into Finschia:dynamic_link Apr 28, 2022
@brew0722 brew0722 deleted the virtual_callstack branch April 28, 2022 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiki-tak shiki-tak shiki-tak approved these changes

@loloicci loloicci loloicci approved these changes

@zemyblue zemyblue Awaiting requested review from zemyblue

Assignees

@brew0722 brew0722

Labels
dynamic_link relate the dynamic link call feature enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brew0722 @shiki-tak @loloicci