-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dynamic callstack for prevent the re-entrancy attack #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brew0722
added
enhancement
New feature or request
dynamic_link
relate the dynamic link call feature
labels
Apr 1, 2022
brew0722
force-pushed
the
virtual_callstack
branch
2 times, most recently
from
April 8, 2022 04:44
6d59eef
to
c40b1da
Compare
8 tasks
- includes max call depth limitation
Even in a running existing contract, a wasmer instance is newly created every call. cannot use the wasmer instance for check the duplication.
brew0722
force-pushed
the
virtual_callstack
branch
from
April 11, 2022 04:50
c40b1da
to
b83dbbc
Compare
rebased to squash merged PR(#182). |
loloicci
reviewed
Apr 19, 2022
loloicci
reviewed
Apr 19, 2022
shiki-tak
reviewed
Apr 21, 2022
shiki-tak
approved these changes
Apr 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
8 tasks
loloicci
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #155 Finschia/wasmvm#62
about integration test,
cannot make the test logic with multiple contracts in the cosmwasm repo.
So I tested manually via
try_reentrancy
msg ofdynamic_caller_contract
.Reentry is well blocked like this(A->B->A):
In order to put the above integration tests structurally into code, it need to go into lbm's
cli_test
.So This will be done after merging into main in the future.
Types of changes
Checklist