Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge main(394d81d) in dynamic_link branch #94

Merged
merged 85 commits into from
Apr 11, 2023

Conversation

da1suk8
Copy link
Member

@da1suk8 da1suk8 commented Mar 13, 2023

Description

bump up dynamic_link branch
I bumped up to 394d81d

This PR is related to Finschia/cosmwasm#271

When Finschia/cosmwasm#271 is merged, update commit-hash, testdata, and build file.

  • commit-hash
  • testdata
  • build file

CI is failing for the same reason as below.
#89 (comment)

CI fails with a race error and this error is caused even without this PR. A test added with this PR catch the race error of the cGetContractEnv.

This issue will be resolved in Finschia/cosmwasm#273

Types of changes

  • Bug fix (changes which fixes an issue)
  • New feature (changes which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ETC (build, ci, docs, perf, refactor, style, test)

Checklist

@da1suk8 da1suk8 self-assigned this Mar 13, 2023
@da1suk8 da1suk8 added the dynamic_link relate the dynamic link call feature label Mar 20, 2023
@da1suk8 da1suk8 marked this pull request as ready for review March 22, 2023 08:59
@dudong2
Copy link

dudong2 commented Mar 27, 2023

In CHANGELOG.md, definitions for each version's links are added at the bottom, but unreleased remains, and there are no definitions for v1.1.1-0.11.0, v1.1.1-0.11.1.

@loloicci
Copy link
Member

LGTM without todo

@da1suk8 da1suk8 changed the title bump up dynamic_link branch merge main(394d81d) in dynamic_link branch Mar 30, 2023
@da1suk8
Copy link
Member Author

da1suk8 commented Apr 4, 2023

@dudong2
Sorry for the late reply.

The unreleased is still in the main, so I left it according to the main.
https://github.com/line/wasmvm/blame/main/CHANGELOG.md#L132-L142

there are no definitions for v1.1.1-0.11.0, v1.1.1-0.11.1.

Do you mean that it is not defined here v1.1.1-0.11.0, v1.1.1-0.11.1?
https://github.com/line/wasmvm/pull/94/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed

@da1suk8 da1suk8 requested a review from dudong2 April 10, 2023 01:26
@da1suk8 da1suk8 merged commit 2c41676 into Finschia:dynamic_link Apr 11, 2023
@da1suk8 da1suk8 deleted the merge_main_394d81d branch April 11, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dynamic_link relate the dynamic link call feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants