Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust/Go Pointer Sharing Issue #273

Closed
13 tasks done
loloicci opened this issue Mar 20, 2023 · 0 comments
Closed
13 tasks done

rust/Go Pointer Sharing Issue #273

loloicci opened this issue Mar 20, 2023 · 0 comments
Assignees
@loloicci
Labels
dynamic_link relate the dynamic link call feature

Comments

@loloicci
Copy link
Member

loloicci commented Mar 20, 2023 •
edited
Loading

https://github.com/line/wasmvm/actions/runs/4300130935/jobs/7496102345?pr=89#step:7:105

GetContractEnv Api has a race error in the way to share the pointer of cache between rust and go.

How to solve

Change how to call callable points in the dynamic link.

Now: rust gets a cache pointer from Go and rust uses it to make a callee instance.
Suggestion: rust requests Go to make callee instance and call a callable point.
@loloicci loloicci self-assigned this Mar 20, 2023
This was referenced Mar 20, 2023
Merged
Closed
Closed
@loloicci loloicci added the dynamic_link relate the dynamic link call feature label Mar 22, 2023
@loloicci loloicci changed the title Rust/Go Pointer Sharing Issue rust/Go Pointer Sharing Issue Mar 22, 2023
This was referenced Mar 23, 2023
Closed
Closed
Closed
loloicci added a commit to loloicci/line-cosmwasm that referenced this issue Mar 29, 2023
@loloicci
feat: add set_callee_permission for Finschia#273
3273134
This was referenced Mar 29, 2023
Merged
Closed
@loloicci loloicci mentioned this issue Apr 7, 2023
Merged
8 tasks
@da1suk8 da1suk8 mentioned this issue Apr 7, 2023
Merged
11 tasks
loloicci added a commit to loloicci/line-cosmwasm that referenced this issue Apr 11, 2023
@loloicci
test: remove verbose tests for dynamic link
9ad7bb0 
some tests in vm/dynamic_link.rs are testing mock.rs's call_callable point.
this is verbose, and this mock will be removed in Finschia#273.
so this commit removes these tests.
loloicci added a commit that referenced this issue Apr 11, 2023
@loloicci
feat: switch how to do dynamic link and validate interface to solve r…
6ce2d99 
…ust/Go pointer sharing issue (#283)

* feat: improve contracts using dynamic link for test new dynamic link functions

* feat: change how to dynamic link and validate interface

* chore: cargo fmt

* chore: cargo fmt

* ci: update rust-toolchain version in ci tests according to latest dynamic link branch

* chore: cargo schema on events contract

* chore: cargo clippy

* chore: cargo clippy for dynamic-caller-contract

* test: remove verbose tests for dynamic link

some tests in vm/dynamic_link.rs are testing mock.rs's call_callable point.
this is verbose, and this mock will be removed in #273.
so this commit removes these tests.
This was referenced Apr 12, 2023
Merged
Closed
Merged
Merged
loloicci added a commit to loloicci/wasmvm that referenced this issue Apr 17, 2023
@loloicci
fix: change depending cosmwasm and remove unused functions on libwasmvm
9e458e1 
- change depnding cosmwasm
- remove unused functions on libwasmvm after solving Finschia/cosmwasm#273
loloicci added a commit to loloicci/wasmvm that referenced this issue Apr 17, 2023
@loloicci
fix: change depending cosmwasm and remove unused functions on libwasmvm
9717fb3 
- change depnding cosmwasm
- remove unused functions on libwasmvm after solving Finschia/cosmwasm#273
@loloicci loloicci mentioned this issue Apr 17, 2023
Merged
8 tasks
loloicci added a commit to Finschia/wasmvm that referenced this issue Apr 17, 2023
@loloicci
fix: Remove unused old dynamiclink features (#106)
90cc195 
* fix: change depending cosmwasm and remove unused functions on libwasmvm

- change depnding cosmwasm
- remove unused functions on libwasmvm after solving Finschia/cosmwasm#273

* fix: remove GetContractEnv from API
@loloicci loloicci mentioned this issue Apr 17, 2023
Merged
5 tasks
This was referenced Apr 20, 2023
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@loloicci loloicci

Labels
dynamic_link relate the dynamic link call feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@loloicci