feat: implement CallCallablePoint to VM #97
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
loloicci
commented
Mar 23, 2023
loloicci
force-pushed
the
rust-go-pointer
branch
4 times, most recently
from
9eb6459
to
f9a5546
Compare
loloicci
force-pushed
the
rust-go-pointer
branch
from
f9a5546
to
bd4e14e
Compare
kokeshiM0chi
approved these changes
Apr 4, 2023
5 tasks
kokeshiM0chi
reviewed
Apr 4, 2023
da1suk8
reviewed
Apr 4, 2023
api/lib.go
Outdated
| // name: Serialized string | ||
| // args: Serialized [][]byte | ||
| // callstack: Serialized []string | ||
| // returned used_gas: without instantiation cost |
There was a problem hiding this comment.
Does used_gas refer to the name of the variable? If so, isn't it gasUsed?
dudong2
previously approved these changes
Apr 4, 2023
kokeshiM0chi
requested changes
Apr 6, 2023
There was a problem hiding this comment.
Would you like to add a test case when the argument isReadonly = true?
postscript: This has been addressed here. Thanks.
8 tasks
- fix to cost gas even if call callable point fails because of permission. - add a test for it - build libwasmvm
kokeshiM0chi
approved these changes
Apr 12, 2023
da1suk8
approved these changes
Apr 12, 2023
8 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR uses Finschia/cosmwasm#272 so updated after it is merged.
This PR implements CallCallablePoint to VM.
This calls a callable point (dynamic linked callee function).
This is a part of Finschia/cosmwasm#273.
Finschia/cosmwasm#273 is solved after this PR is merged and API for rust using CallCallablePoint is implemented.
Types of changes
Checklist