Skip to content

Commit

Permalink
BUG/MEDIUM: mux-h2: Refuse interim responses with end-stream flag set
Browse files Browse the repository at this point in the history
As state in RFC9113#8.1, HEADERS frame with the ES flag set that carries an
informational status code is malformed. However, there is no test on this
condition.

On 2.4 and higher, it is hard to predict consequences of this bug because
end of the message is only reported with a flag. But on 2.2 and lower, it
leads to a crash because there is an unexpected extra EOM block at the end
of an interim response.

Now, when a ES flag is detected on a HEADERS frame for an interim message, a
stream error is sent (RST_STREAM/PROTOCOL_ERROR).

This patch should solve the issue haproxy#1972. It should be backported as far as
2.0.

(cherry picked from commit 827a629)
Signed-off-by: Willy Tarreau <w@1wt.eu>
(cherry picked from commit ebfae00)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
  • Loading branch information
capflam committed Jan 20, 2023
1 parent b118355 commit 84f5cba
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions src/mux_h2.c
Original file line number Diff line number Diff line change
Expand Up @@ -4985,6 +4985,11 @@ static int h2c_decode_headers(struct h2c *h2c, struct buffer *rxbuf, uint32_t *f
*flags |= H2_SF_HEADERS_RCVD;

if (h2c->dff & H2_F_HEADERS_END_STREAM) {
if (msgf & H2_MSGF_RSP_1XX) {
/* RFC9113#8.1 : HEADERS frame with the ES flag set that carries an informational status code is malformed */
TRACE_STATE("invalid interim response with ES flag!", H2_EV_RX_FRAME|H2_EV_RX_HDR|H2_EV_H2C_ERR|H2_EV_PROTO_ERR, h2c->conn);
goto fail;
}
/* no more data are expected for this message */
htx->flags |= HTX_FL_EOM;
}
Expand Down

0 comments on commit 84f5cba

Please sign in to comment.