Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep GitHub Actions up to date with Dependabot #343

Merged
merged 2 commits into from
May 20, 2024
Merged

Keep GitHub Actions up to date with Dependabot #343

merged 2 commits into from
May 20, 2024

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Feb 18, 2024 •
edited
Loading

oyvindwe
oyvindwe reviewed Feb 19, 2024
View reviewed changes
Copy link

@oyvindwe oyvindwe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I don't see how this PR actually solves the issues listed in the PR description?

@cclauss
Copy link
Contributor Author

cclauss commented Feb 19, 2024

I don't see how this PR actually solves the issues.

Landing this will cause Dependabot to auto-generate a new pull reqest that will solve those issues. A bit indirect.

jhuleatt
jhuleatt approved these changes May 20, 2024
View reviewed changes
Copy link
Collaborator

@jhuleatt jhuleatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thank you @cclauss!

@jhuleatt jhuleatt merged commit d482eb9 into FirebaseExtended:main May 20, 2024
1 check passed
@cclauss cclauss deleted the patch-1 branch May 20, 2024 20:39
@Plumshubparall
Copy link

perfecto

@FirebaseExtended FirebaseExtended locked and limited conversation to collaborators Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@oyvindwe oyvindwe oyvindwe left review comments

@jhuleatt jhuleatt jhuleatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node.js 16 actions are deprecated Upgrade current action to use node 16 instead of 12
4 participants
@cclauss @Plumshubparall @jhuleatt @oyvindwe