Skip to content

Commit

Permalink
Merge pull request #613 from firebase/kato-error
Browse files Browse the repository at this point in the history
Fixes #589 - Cannot read property $$error of null
  • Loading branch information
davideast committed May 1, 2015
2 parents c7ad7d8 + d8c12c6 commit 86ea97e
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
4 changes: 3 additions & 1 deletion src/FirebaseArray.js
Original file line number Diff line number Diff line change
Expand Up @@ -672,7 +672,9 @@
var isResolved = false;
var error = $firebaseUtils.batch(function(err) {
_initComplete(err);
firebaseArray.$$error(err);
if( firebaseArray ) {
firebaseArray.$$error(err);
}
});
var initComplete = $firebaseUtils.batch(_initComplete);

Expand Down
7 changes: 6 additions & 1 deletion src/FirebaseObject.js
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,12 @@
firebaseObject.$$notify();
}
});
var error = $firebaseUtils.batch(firebaseObject.$$error, firebaseObject);
var error = $firebaseUtils.batch(function(err) {
_initComplete(err);
if( firebaseObject ) {
firebaseObject.$$error(err);
}
});
var initComplete = $firebaseUtils.batch(_initComplete);

var sync = {
Expand Down

0 comments on commit 86ea97e

Please sign in to comment.